Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix joining a room twice #1311

Closed
kegsay opened this issue Aug 24, 2020 · 7 comments · May be fixed by matrix-org/sytest#960
Closed

Fix joining a room twice #1311

kegsay opened this issue Aug 24, 2020 · 7 comments · May be fixed by matrix-org/sytest#960
Labels
are-we-synapse-yet This issue or PR involves Sytests in AWSY good first issue Want to help with Dendrite? These are the issues to start with!

Comments

@kegsay
Copy link
Member

kegsay commented Aug 24, 2020

Sytests:

    × Joining room twice is idempotent
@kegsay kegsay added good first issue Want to help with Dendrite? These are the issues to start with! are-we-synapse-yet This issue or PR involves Sytests in AWSY labels Aug 24, 2020
@neilalexander neilalexander mentioned this issue Sep 24, 2020
Open
@MadLittleMods MadLittleMods mentioned this issue Dec 18, 2020
Closed
@Tert0
Copy link

Tert0 commented Aug 28, 2021 •
edited

I get

Test 138 Joining room twice is idempotent... EXPECTED FAIL

as output for SyTests.

Does that mean that it works?

@kegsay
Copy link
Member Author

kegsay commented Sep 6, 2021

No, it should be ... OK

@ZofiaZementa
Copy link

ZofiaZementa commented Oct 27, 2021 •
edited

@Tert0 are you working on this? Otherwise I'd like to take a swing at it
Edit: Nvm, just saw above that this seems to be an issue with the tests, I don't think i know enough to fix that

@nicobao
Copy link

nicobao commented Jan 17, 2022

Hi,
I am looking at it.

@kegsay
Copy link
Member Author

kegsay commented May 23, 2022

Still failing as of today.

@nicobao
Copy link

nicobao commented May 23, 2022 •
edited

Still failing as of today.

I had started and struggled at logging the relevant logs from the Perl fixture. I tried to figure out what part of the Go code was called.
Then, for some reason I thought I received a notification that someone had fixed it that's why I didn't update my previous post. My apologies for misleading you that I would fix the issue. Unfortunately, I won't have time to go further for a while, I am overwhelmed with work. So if anyone wants, please do go ahead and fix this issue.

@S7evinK
Copy link
Contributor

S7evinK commented Jun 9, 2022

Fixed in #2512 or rather in matrix-org/sytest#1256

@S7evinK S7evinK closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
are-we-synapse-yet This issue or PR involves Sytests in AWSY good first issue Want to help with Dendrite? These are the issues to start with!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update state idempotency tests to not use initialsync matrix-org/sytest
5 participants
@S7evinK @kegsay @ZofiaZementa @nicobao @Tert0