New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lua plugins + network bandwidth plugin in lua #1084

Merged
merged 6 commits into from Aug 25, 2018

Conversation

Projects
None yet
2 participants
@cpbotha
Contributor

cpbotha commented Aug 24, 2018

This plugin shows current total bandwidth over user-specified interfaces, with separate interfaces in context menu.

It is written in lua with a single call to ifstat. It is 30% smaller (peak memory use) and slightly faster than the bash + ifstat + awk versions.

@cpbotha

This comment has been minimized.

Show comment
Hide comment
@cpbotha

cpbotha Aug 24, 2018

Contributor

I see that the Travis CI build failed because: /Users/travis/build/matryer/bitbar-plugins/Network/bandwidth_total.2s.lua unrecognized file extension

Would you consider adding lua? It's a single brew install lua away. :)

Contributor

cpbotha commented Aug 24, 2018

I see that the Travis CI build failed because: /Users/travis/build/matryer/bitbar-plugins/Network/bandwidth_total.2s.lua unrecognized file extension

Would you consider adding lua? It's a single brew install lua away. :)

@cpbotha

This comment has been minimized.

Show comment
Hide comment
@cpbotha

cpbotha Aug 24, 2018

Contributor

I have added support for lua plugins, including the luacheck linter.

Contributor

cpbotha commented Aug 24, 2018

I have added support for lua plugins, including the luacheck linter.

cpbotha added some commits Aug 24, 2018

Brew install luarocks instead of lua
We need luarocks to install luacheck for linting lua plugins. Brew
installing luarocks will automatically pull in a suitable version of
lua.
Fix bitbar metadata
There was a typo in the github author, and the bitbar.desc was not
correctly recognized, probably because too long over multiple lines.

@cpbotha cpbotha changed the title from Show total bandwidth for specified ifaces with lua to Add support for lua plugins + network bandwidth plugin in lua Aug 24, 2018

Monitor all active interfaces
This does not require any user configuration.
@tresni

This comment has been minimized.

Show comment
Hide comment
@tresni

tresni Aug 25, 2018

Collaborator

Normally, we don't like to have multiple plugins doing the same thing. But given you've added support for a whole new language, I'm going to allow it.

Collaborator

tresni commented Aug 25, 2018

Normally, we don't like to have multiple plugins doing the same thing. But given you've added support for a whole new language, I'm going to allow it.

@tresni tresni merged commit 24a8e67 into matryer:master Aug 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cpbotha

This comment has been minimized.

Show comment
Hide comment
@cpbotha

cpbotha Aug 26, 2018

Contributor

Thank you for merging, much appreciated!

Hopefully now we'll see more small lua plugins.

Contributor

cpbotha commented Aug 26, 2018

Thank you for merging, much appreciated!

Hopefully now we'll see more small lua plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment