Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text isn't vertically aligned correctly in the menu bar #105

Open
tombonez opened this issue Jan 6, 2016 · 17 comments
Open

Text isn't vertically aligned correctly in the menu bar #105

tombonez opened this issue Jan 6, 2016 · 17 comments
Labels
bug

Comments

@tombonez
Copy link
Contributor

@tombonez tombonez commented Jan 6, 2016

Hi,

As seen in the screenshot below, the text isn't vertically aligned correctly in the menu bar.

screenshot 2016-01-05 10 18 07

Cheers,
Tom :)

@herdani

This comment has been minimized.

Copy link

@herdani herdani commented Jan 6, 2016

+1

@matryer

This comment has been minimized.

Copy link
Owner

@matryer matryer commented Jan 6, 2016

Why on earth not?

@matryer

This comment has been minimized.

Copy link
Owner

@matryer matryer commented Jan 6, 2016

If anyone wants to try and figure this out - please do. I had a look, and there's nothing (except that it's attributed text) that makes me think it would be.

I 100% agree we should fix it though.

@matryer matryer added the bug label Jan 6, 2016
@matryer

This comment has been minimized.

Copy link
Owner

@matryer matryer commented Jan 6, 2016

@muhqu any ideas on this one?

@tombonez

This comment has been minimized.

Copy link
Contributor Author

@tombonez tombonez commented Jan 9, 2016

Just submitted a pull request to fix this #153 :)

@thomasbachem

This comment has been minimized.

Copy link
Contributor

@thomasbachem thomasbachem commented Jan 10, 2016

The fix from #153 sadly only works well with the default font size (14).

v1.4beta rendered size=11 like this (vertically centered):

bitbar-1-4b-size11

And now v1.4 looks like this:

bitbar-1-4-size11

@tombonez

This comment has been minimized.

Copy link
Contributor Author

@tombonez tombonez commented Jan 10, 2016

Ah, I wasn't aware of user specified font sizes (sorry) :(

I'll try and look into this again today :)

@matryer

This comment has been minimized.

Copy link
Owner

@matryer matryer commented Jan 16, 2016

Is there a general way to solve this problem? @tombonez any ideas?

@Eraac

This comment has been minimized.

Copy link

@Eraac Eraac commented Mar 30, 2017

just installed bitbar today (1.9.2), I gave create a simple plugin just write some number, no specific size or font, but text is not centered too :/

I have try v2, but same problem. Any solution ?

My plugin just display the current timestamp

@dmcinnes

This comment has been minimized.

Copy link

@dmcinnes dmcinnes commented May 31, 2017

I'm still seeing this problem in 1.9.2:
screen shot 2017-05-31 at 1 40 28 pm
Left is Bitbar with World Clock and right is the system clock in MacOS 10.12.5.

@oleander

This comment has been minimized.

Copy link

@oleander oleander commented Jun 1, 2017

No fix atm. The problem is that no default font is set on the text which is required for items in the menu bar to look correct in OS X 10.11+.

@klamike

This comment has been minimized.

Copy link

@klamike klamike commented Oct 19, 2017

Is there a fix for the vertical alignment issue?

@thomasbachem

This comment has been minimized.

Copy link
Contributor

@thomasbachem thomasbachem commented Aug 16, 2018

@oleander You mean BitBar just needs to specify a default font? That sounds like a rather easy fix for a quite annoying bug?

@marqpdx

This comment has been minimized.

Copy link

@marqpdx marqpdx commented Aug 29, 2018

Where might that default font be set, if that is actually a fix? It does sound like it would be one or a few lines. Which lines, and where to put them is of course the question :)

@marqpdx

This comment has been minimized.

Copy link

@marqpdx marqpdx commented Sep 1, 2018

OK, been looking at the code. It seems one sets the font for the menu items, but it seems in our case, the actual menu itself is too big (as you can see w/ the UTC time vs the battery % to the right).

The menu items themselves, though, seem to be proper size.

Do we need to set the default font for all menu items, will that take care of the Menu font itself?

Thanks,
m

screen shot 2018-09-01 at 8 37 14 am
screen shot 2018-09-01 at 8 36 34 am

@XanderLeaDaren

This comment has been minimized.

Copy link

@XanderLeaDaren XanderLeaDaren commented Oct 21, 2019

Solved by @cedivad in #513 !

@inbalboa

This comment has been minimized.

Copy link

@inbalboa inbalboa commented Oct 21, 2019

The repo https://github.com/guillaumewuip/bitbar from #513 (comment) is unavailable. So there is still no solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.