Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it difficult to remove the OCaml <= 4.01 requirement? #354

Open
wwood opened this issue Feb 9, 2017 · 4 comments

Comments

@wwood
Copy link

commented Feb 9, 2017

Hi,

First off, thanks for writing pplacer, it has become a quite central tool for our group, even if we don't use it directly instead via tools which I'll refrain from advertising.

Accordingly, we are wanting to package pplacer for the GNU Guix package manager / OS, and I've got it working locally:
http://lists.gnu.org/archive/html/guix-devel/2017-02/msg00273.html

However, it would simplify maintenance of the package if the newest version of OCaml could be used rather than 4.01 (and this would presumably be true for others building from source too). Without having a great amount of experience with OCaml, is updating likely to be a difficult thing?
Thanks, ben.

@rekado

This comment has been minimized.

Copy link

commented Apr 9, 2019

Meanwhile, pplacer has been removed from Guix due to its dependency on OCaml 4.01, which is affected by an unfixed CVE.

@rekado

This comment has been minimized.

Copy link

commented Apr 9, 2019

I patched the sources to build with OCaml 4.02. Here's the patch series to add pplacer to GNU Guix again: https://issues.guix.info/issue/35207

@rekado

This comment has been minimized.

Copy link

commented Apr 11, 2019

I've patched pplacer to build with OCaml 4.07.1. Here's the patch adding it to Guix:
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=36f4f1e297941877439eca77f24d7400da3a51f9

@matsen

This comment has been minimized.

Copy link
Owner

commented Apr 29, 2019

Hey @rekado thanks for this!

I've been away so am just catching up. Does this require pplacer code changes, or just packaging changes? If the former, would you like to submit a PR against the main repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.