Implement Nginx::SSL.errlogger (and Nginx::SSL.log) #215

Merged
merged 2 commits into from Sep 26, 2016

Projects

None yet

2 participants

@hfm
Collaborator
hfm commented Sep 26, 2016

No description provided.

@hfm hfm changed the title from [wip] Implement Nginx::SSL.errlogger (and Nginx::SSL.log) to Implement Nginx::SSL.errlogger (and Nginx::SSL.log) Sep 26, 2016
src/http/ngx_http_mruby_ssl.c
+ mrb_define_const(mrb, class_ssl, "LOG_WARN", mrb_fixnum_value(NGX_LOG_WARN));
+ mrb_define_const(mrb, class_ssl, "LOG_NOTICE", mrb_fixnum_value(NGX_LOG_NOTICE));
+ mrb_define_const(mrb, class_ssl, "LOG_INFO", mrb_fixnum_value(NGX_LOG_INFO));
+ mrb_define_const(mrb, class_ssl, "LOG_DEBUG", mrb_fixnum_value(NGX_LOG_DEBUG));
@matsumotory
matsumotory Sep 26, 2016 edited Owner

Why did you re-implement error log constants for Nginx::SSL class instead of Nginx core class constants like Nginx::LOG_NOTICE?

@hfm
hfm Sep 26, 2016 Collaborator

I thought it better to re-implement them because Nginx::Stream class has LOG constants. But, come to think of it, I need not have re-implemented them.

I'll remove them.

@matsumotory
matsumotory Sep 26, 2016 Owner

Nginx::Stream doesn't have the core class. So, it need to re-implement the constants. While Nginx::SSL have the core class.

@hfm
hfm Sep 26, 2016 Collaborator

Thanks, I understood it.

@matsumotory
Owner

Thank you for your PR. Your code looks good to me. I commented only one question. Please check it.

@matsumotory
Owner

Thank you for the change. I'll merge after CI.

@matsumotory matsumotory merged commit b4c5bf5 into matsumotory:master Sep 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hfm hfm deleted the hfm:ssl-errlogger branch Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment