Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Paths #45

Closed
GuacheSuede opened this issue Feb 27, 2017 · 8 comments
Closed

Custom Paths #45

GuacheSuede opened this issue Feb 27, 2017 · 8 comments

Comments

@GuacheSuede
Copy link

Hi Matt,
how does one go about writing custom paths such as /hello/John and getting John as a param ?

Thank You

@matt-42
Copy link
Owner

matt-42 commented Feb 27, 2017

Here is a small API doing what you want:
auto hello_api = http_api(
GET / _hello / _name[std::string()] = [] (auto params) { return "hello " + params.name; }
);

Does it answer your question ?

@GuacheSuede
Copy link
Author

Thank you Matt, yes it does.

Quick question, i notice alot of commented out code in lwan.hh, what does that mean ?
Also, lwan is no longer compatible with Silicon due to breaking changes, mass renames of lwan variables

@matt-42
Copy link
Owner

matt-42 commented Feb 27, 2017

It's true that I did not work on it since quite some time. I'll revamp it if you need it.
In the meantime, you can use the mhd backend which is more stable and up to date.

@GuacheSuede
Copy link
Author

GuacheSuede commented Feb 27, 2017

Alright sure, i made some changes to the official lwan repo(merged) to fix some breaking changes, you are mostly left to deal with variable renames.

Would you consider officially supporting the lwan backend, on the TechEmpower benchmark, it trumps every other webserver including mhd, lwan has a good history of commits and active ?

@matt-42
Copy link
Owner

matt-42 commented Feb 27, 2017

Lwan compile with my last commit 5737203, and with another C++ fix I've submitted to Lwan's master.

I included LWAN in the techempower 13th round : https://www.techempower.com/benchmarks/#section=data-r13&hw=ph&test=db&l=4fs3jz
It was able to better handle the heavy load of the plaintext example (up to 16k connections), but it was pretty much on par with MHD on the other tests.

@matt-42 matt-42 closed this as completed Feb 27, 2017
@GuacheSuede
Copy link
Author

@matt-42 Thank you for the changes, made some further compilation changes

@matt-42
Copy link
Owner

matt-42 commented Feb 27, 2017

Keep in mind that POST requests does not work anymore. I don't know yet if it's due to silicon or lwan.

@GuacheSuede
Copy link
Author

GuacheSuede commented Feb 27, 2017

@matt-42 I am testing lwan without Silicon now, POSTS definitely works on LWAN, using your pull request. Do inform me if you need any help on the lwan side :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants