This repository has been archived by the owner on Feb 9, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please describe.
PHP-CS-Fixer 3.x has been released recently, and I was hoping to start using it.
Describe the solution you'd like
A new release with support for 3.x. 馃憤馃徎
I've started working on the transition to the new version. I was initially going to try and get it working with the new rule names (which still work on PHP-CS-Fixer 2.x), and then eventually migrate to v3.
It looks like the issues I've hit so far are as follows:
Config::setRules()
method now has a return type ofPhpCsFixer\ConfigInterface
which means that we can't cover both v2.x and v3.x with the same config class unfortunately. Unless I'm mistaken.(resolved by ignoring that test in ci: update to test PHP 8聽#48)class_definition
is causing issues with Laravel 8, although this seems to be covered by Braces on anonymous classes聽#47 and is a separate issue.I've currently used
.php-cs-fixer.dist.php
as the config name, but I'm happy to go with.php-cs-fixer.php
instead if that would be better.Describe alternatives you've considered
N/A
Additional context
N/A