New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collection export doesn't correctly handle quotes in song titles #65

Closed
bgentry opened this Issue Nov 17, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@bgentry
Copy link

bgentry commented Nov 17, 2015

This is the first 3 lines of my exported Rdio collection:

Name,Artist,Album,Track Number
""Is This My Fate," He Asked Them","Story Of The Year","In The Wake Of Determination","12"
""The Take Over, The Breaks Over"","Fall Out Boy","Infinity On High (Deluxe Edition)","2"

Unfortunately, this isn't valid CSV. You can surround comma-containing strings in double quotes as you've done here, but then you also need to escape double quotes with a "". So I think the correct output would be:

Name,Artist,Album,Track Number
"""Is This My Fate,"" He Asked Them","Story Of The Year","In The Wake Of Determination","12"
"""The Take Over, The Breaks Over""","Fall Out Boy","Infinity On High (Deluxe Edition)","2"

I've confirmed with Golang's CSV parser that this is indeed parseable and valid.

@matt-h matt-h closed this in 9ab290b Nov 17, 2015

@bgentry

This comment has been minimized.

Copy link

bgentry commented Nov 17, 2015

@matt-h awesome, thank you!

@gingold

This comment has been minimized.

Copy link

gingold commented Nov 18, 2015

I ended up with the following:

Name,Artist,Album,Track Number
"""Is That Really It?"","Disjecta","Clean Pit & Lid","9"

Seems to be missing the final quote in the first field.

matt-h added a commit that referenced this issue Nov 18, 2015

@matt-h

This comment has been minimized.

Copy link
Owner

matt-h commented Nov 18, 2015

Thanks for the feedback @gingold
This should be fixed now in v2.10.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment