Convert getMessageArray test case to regex

mattbasta · Feb 11, 2013 · ae12c82 · ae12c82
1 parent fb3113b
commit ae12c82
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 23 deletions.
diff --git a/validator/testcases/javascript/entity_values.py b/validator/testcases/javascript/entity_values.py
@@ -242,25 +242,6 @@ def on_open(wrapper, arguments, traverser):
     return {"return": on_open}
 
 
-@register_entity("nsIConsoleService.getMessageArray")
-def nsIConsoleService_GetMessageArray(traverser):
-    traverser.err.notice(
-        err_id=("testcases_javascript_entity_values",
-                "nsIConsoleService.getMessageArray"),
-        notice="`getMessageArray` has changed",
-        description="The `getMessageArray` function has changed, and now it "
-                    "returns the array instead of setting the object passed "
-                    "as a parameter. See %s for more information." %
-                    BUGZILLA_BUG % 664695,
-        filename=traverser.filename,
-        line=traverser.line,
-        column=traverser.position,
-        context=traverser.context,
-        for_appversions=FX19_DEFINITION,
-        compatibility_type="error",
-        tier=5)
-
-
 # Thunderbird 14 IDL changes
 @register_entity("nsIMsgPluggableStore.copyMessages")
 def nsIMsgPluggableStore_copyMessages(traverser):

diff --git a/validator/testcases/javascript/predefinedentities.py b/validator/testcases/javascript/predefinedentities.py
@@ -100,10 +100,6 @@
                         e.get_resource("em:bootstrap") and
                         "Authors of bootstrapped add-ons must take care to "
                         "clean up any component registrations at shutdown."}}},
-    u"nsIConsoleService":
-        {"value":
-            {u"getMessageArray":
-                entity("nsIConsoleService.getMessageArray")}},
     u"nsIDOMNSHTMLElement": entity("nsIDOMNSHTMLElement"),
     u"nsIDOMNSHTMLFrameElement": entity("nsIDOMNSHTMLFrameElement"),
     u"nsIDNSService": {"value": {u"resolve": entity("nsIDNSService.resolve")}},

diff --git a/validator/testcases/regex.py b/validator/testcases/regex.py
@@ -835,6 +835,13 @@ def js_tests(self):
             "require an additional argument to specify a context.",
             compat_type="error", log_function=self.err.notice)
 
+        yield self.get_test_bug(
+            664695, "getMessageArray",
+            "`nsIConsoleService::getMessageArray` has been changed.",
+            "The `getMessageArray` function has changed, and now it returns "
+            "the array instead of setting the object passed as a parameter.",
+            compat_type="error", log_function=self.err.notice)
+
 
 @register_generator
 class Thunderbird7RegexTests(CompatRegexTestHelper):