Permalink
Browse files

Made jsmain work, fixed document.write() noise

And some whitespace.
  • Loading branch information...
1 parent 95b4e94 commit 02c59c2892405276232d2b45b2e15356f12b0ada @mattbasta committed Nov 28, 2012
Showing with 8 additions and 7 deletions.
  1. +6 −4 appvalidator/testcases/javascript/actions.py
  2. +0 −1 appvalidator/testcases/webappbase.py
  3. +2 −2 jsmain.py
@@ -621,10 +621,12 @@ def _expr_binary(traverser, node):
# Dirty l or r values mean we can skip the expression. A dirty value
# indicates that a lazy operation took place that introduced some
# nondeterminacy.
- if left.dirty:
- return left
- elif right.dirty:
- return right
+ if operator != "+":
+ # We don't want this to apply to concatenation.
+ if left.dirty:
+ return left
+ elif right.dirty:
+ return right
# Binary expressions are only executed on literals.
left_wrap = left
@@ -237,4 +237,3 @@ def test_developer(branch):
test_developer(manifest.get("developer"))
for locale, locale_data in manifest.get("locales", {}).items():
test_developer(locale_data.get("developer"))
-
View
@@ -4,8 +4,8 @@
import os
from appvalidator.constants import SPIDERMONKEY_INSTALLATION
-from appvalidator.errorbundler import ErrorBundle
-from appvalidator.outputhandlers.shellcolors import OutputHandler
+from appvalidator.errorbundle import ErrorBundle
+from appvalidator.errorbundle.outputhandlers.shellcolors import OutputHandler
import appvalidator.testcases.scripting as scripting
import appvalidator.testcases.javascript.traverser
from appvalidator.testcases.javascript.predefinedentities import GLOBAL_ENTITIES

0 comments on commit 02c59c2

Please sign in to comment.