Removed junk Java test from amo-validator

appvalidator/testcases/packagelayout.py

@@ -17,10 +17,6 @@
         (0x43, 0x57, 0x53),  # ZLIB compressed SWF
 )
 
-# If there are more than 10 .class files in a package, it is flagged as a Java
-# archive file.
-JAVA_JAR_THRESHOLD = 10
-
 
 @register_test(tier=1)
 def test_blacklisted_files(err, package=None):
@@ -72,32 +68,20 @@ def test_blacklisted_files(err, package=None):
 
     if flagged_files:
         # Detect Java JAR files:
-        if (sum(1 for f in flagged_files if f.endswith(".class")) >
-                JAVA_JAR_THRESHOLD):
-            err.notice(
-                err_id=("testcases_packagelayout",
-                        "test_blacklisted_files",
-                        "java_jar"),
-                notice="Java JAR file detected.",
-                description="A Java JAR file was detected in the add-on.",
-                filename=package.filename)
-        else:
-            err.warning(
-                err_id=("testcases_packagelayout",
-                        "test_blacklisted_files",
-                        "disallowed_extension"),
-                warning="Flagged file extensions found.",
-                description=["Files whose names end with flagged extensions "
-                             "have been found in the add-on.",
-                             "The extension of these files are flagged because "
-                             "they usually identify binary components. Please "
-                             "see "
-                             "http://addons.mozilla.org/developers/docs/"
-                                 "policies/reviews#section-binary"
-                             " for more information on the binary content "
-                             "review process.",
-                             "\n".join(flagged_files)],
-                filename=name)
+        err.warning(
+            err_id=("testcases_packagelayout",
+                    "test_blacklisted_files",
+                    "disallowed_extension"),
+            warning="Flagged file extensions found.",
+            description=["Files whose names end with flagged extensions have "
+                         "been found in the add-on.",
+                         "The extension of these files are flagged because "
+                         "they usually identify binary components. Please see "
+                         "http://addons.mozilla.org/developers/docs/"
+                             "policies/reviews#section-binary"
+                         " for more information on the binary content review "
+                         "process.", "\n".join(flagged_files)],
+            filename=name)
 
 
 @register_test(tier=1)

tests/test_packagelayout.py

@@ -18,21 +18,6 @@ def test_blacklisted_files():
     assert err.metadata["contains_binary_extension"]
 
 
-def test_java_jar_detection():
-    """
-    Test that Java archives are flagged as such so that they do not generate
-    hundreds or thousands of errors.
-    """
-
-    classes = ("c%d.class" % i for i in xrange(1000))
-    mock_xpi = MockXPI(dict(zip(classes, repeat(""))))
-    err = ErrorBundle()
-    packagelayout.test_blacklisted_files(err, mock_xpi)
-
-    assert not err.failed()
-    assert err.notices
-
-
 def test_blacklisted_magic_numbers():
     "Tests that blacklisted magic numbers are banned"