Permalink
Browse files

Don't actually download the developer URLs (bug 843061)

  • Loading branch information...
1 parent ed9ea60 commit bb197d09e3e2465b6f590740405f22e4f4e7fd58 @mattbasta committed Mar 18, 2013
Showing with 6 additions and 2 deletions.
  1. +6 −2 appvalidator/testcases/webappbase.py
@@ -103,7 +103,7 @@ def _normalize_url(err, url):
def try_get_resource(err, package, url, filename, resource_type="URL",
- max_size=True):
+ max_size=True, simulate=False):
# Try to process data URIs first.
if url.startswith("data:"):
@@ -137,6 +137,9 @@ def try_get_resource(err, package, url, filename, resource_type="URL",
else:
url = _normalize_url(err, url)
+ if simulate:
+ return
+
http_cache = err.get_or_create('http_cache', {})
if url in http_cache:
return http_cache[url]
@@ -352,7 +355,8 @@ def test_developer(branch):
if branch and "url" in branch:
try_get_resource(err, package, branch["url"],
filename="webapp.manifest",
- resource_type="developer url", max_size=False)
+ resource_type="developer url",
+ max_size=False, simulate=True)
test_developer(manifest.get("developer"))
for locale, locale_data in manifest.get("locales", {}).items():

0 comments on commit bb197d0

Please sign in to comment.