Skip to content

Commit

Permalink
Don't actually download the developer URLs (bug 843061)
Browse files Browse the repository at this point in the history
  • Loading branch information
mattbasta committed Mar 18, 2013
1 parent ed9ea60 commit bb197d0
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions appvalidator/testcases/webappbase.py
Expand Up @@ -103,7 +103,7 @@ def _normalize_url(err, url):


def try_get_resource(err, package, url, filename, resource_type="URL",
max_size=True):
max_size=True, simulate=False):

# Try to process data URIs first.
if url.startswith("data:"):
Expand Down Expand Up @@ -137,6 +137,9 @@ def try_get_resource(err, package, url, filename, resource_type="URL",
else:
url = _normalize_url(err, url)

if simulate:
return

http_cache = err.get_or_create('http_cache', {})
if url in http_cache:
return http_cache[url]
Expand Down Expand Up @@ -352,7 +355,8 @@ def test_developer(branch):
if branch and "url" in branch:
try_get_resource(err, package, branch["url"],
filename="webapp.manifest",
resource_type="developer url", max_size=False)
resource_type="developer url",
max_size=False, simulate=True)

test_developer(manifest.get("developer"))
for locale, locale_data in manifest.get("locales", {}).items():
Expand Down

0 comments on commit bb197d0

Please sign in to comment.