Skip to content
This repository
Browse code

Merge pull request #3 from eviljeff/patch-4

add all orientation values to validator
  • Loading branch information...
commit d791218125062f08538722fb99fe50967ace99a3 2 parents 05d7845 + d6db217
Matt Basta authored
3  appvalidator/specs/webapps.py
@@ -371,7 +371,8 @@ def process_act_type(self, node):
371 371
 
372 372
     def process_orientation(self, node):
373 373
         values = [u"portrait", u"landscape", u"portrait-secondary",
374  
-                  u"landscape-secondary"]
  374
+                  u"landscape-secondary", u"portrait-primary", 
  375
+                  u"landscape-primary"]
375 376
         message = ("The value provided for a webapp's orientation should be "
376 377
                    "either a string or an array of strings.")
377 378
 
3  tests/test_webapp.py
@@ -448,7 +448,8 @@ def test_orientation(self, orientation):
448 448
             self.assert_silent()
449 449
 
450 450
         for key in ("portrait", "landscape", "portrait-secondary",
451  
-                    "landscape-secondary",):
  451
+                    "landscape-secondary", "portrait-primary",
  452
+                    "landscape-primary"):
452 453
             yield test_orientation, self, key
453 454
 
454 455
     def test_orientation_bad_value(self):

0 notes on commit d791218

Please sign in to comment.
Something went wrong with that request. Please try again.