Dfries gh pages fixes #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows processing images in a Node.js Buffer that aren't in a local file (such as streamed images).
Buffer was read with 100000, no need to expand to 1000000, and if 100000 is enough for reading a file it should be enough for any image passed in through a buffer, otherwise it needs to be increased in both places. Adding a variable to use the same size in all three locations. Allocate a buffer no bigger than the current buffer, rather than always the full size.
I'm finding that some exif strings are NULL terminated and some aren't. Avoid the "TODO: but I'm not sure why", by always reading the value length characters and then removing from the first NULL or any terminating spaces. I see the "motion" webcam motion detection program will NULL terminate dates, but not Image Description, and previously "iNumValues - 1" would truncate the last character.
This way just the non-printable ones are discarded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing in the great contributions from dfries (thanks!).
Updated all the json files with the current outputs for test purposes. Trying to move away from that mess though and so added some tests (see the unit tests at the bottom of test/test.js).