New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squash fsevents errors (which are not errors on Linux) #241

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@aral
Copy link
Contributor

aral commented Jan 15, 2019

On non-macOS systems, the following error is logged to the console on every rebuild:

Error: Cannot find module 'fsevents' from '…/node_modules/chokidar/lib'

fsevents is a macOS-only module and should not be causing errors on other platforms.

This PR squashes that specific error.

@aral

This comment has been minimized.

Copy link
Contributor Author

aral commented Jan 15, 2019

All tests passing on Node v10.14.2 under ~Ubuntu 18.10 (Pop!_OS 18.10)

@mattdesl

This comment has been minimized.

Copy link
Owner

mattdesl commented Jan 16, 2019

Thanks! Can you provide a few more details? It seems like this is a bit of a hack, and will fail in some legitimate cases, e.g. if a user tries to require fsevents or some module that depends on it from within their client code. From what I understand, this method shouldn't even be called for non-client errors, so I'm not sure why this is even fixing your issue.

Are you getting this issue on a simple app like so:

// index.js
console.log("Hello, World");
# in terminal
budo index.js:bundle.js --live
@aral

This comment has been minimized.

Copy link
Contributor Author

aral commented Jan 16, 2019

Hey Matt, yeah I agree it’s hackish. Looks like the issue stems from Chokidar and has come up in various guises multiple times.

Can’t reproduce with your simple test.

I don’t mind if you close this. It will still come up in searches in case anyone else is affected.

@mattdesl

This comment has been minimized.

Copy link
Owner

mattdesl commented Jan 16, 2019

Hmm odd, is there any small reproducible test case that emits the error for you? It sounds like you are requiring (in your browser/client code) some module that happens to require chokidar or fsevents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment