Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

now the data captured while encoding WAV is not lost #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mido22
Copy link

@Mido22 Mido22 commented Sep 20, 2014

this is especially helpful when you are sending chunks of wav to server.

…l when you are sending chunks of wav to server)
@Rillke
Copy link

Rillke commented Mar 11, 2015

Since the worker lives in a single thread and there are no asynchronous operations in recorderWorker.js, under which circumstances, data is lost? I would expect that as soon as encoding starts, everything else in this worker is blocked and the messages containing data are piling up in the browser's event queue, thus if a clear is the first item in the queue, all data is added to fresh buffer-holding arrays. Only if the clear is issued somewhere later, data is lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants