v1.4.2 — fix mod+shift+. shortcut on Windows#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #32. Fixes
mod+shift+.(editor-only toggle) silently dropping on Windows (and would on any layout whereshift+.produces a differente.key).Root cause
use-shortcuts.ts:34matchede.key.toLowerCase() === wantKey. On US layouts,Shift+.producese.key === ">", so the literal"."in shortcut definitions never matched when shift was held. macOS happened to dodge it because users typically discover the command via the palette, not the shortcut.Fix
Added
SHIFTED_KEY_CODESmap (.→"Period",,→"Comma", etc) and ane.codefallback: ife.keydoesn't match the literal shortcut char, also try matching against the physical key code. Layout-independent + future-proofs other shifted-symbol shortcuts.Test plan
🤖 Generated with Claude Code