Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some documentation for #184 #224

Merged
merged 1 commit into from Mar 2, 2018

Conversation

StFS
Copy link
Contributor

@StFS StFS commented Mar 1, 2018

This PR documents the changes made to the handling of null values in properties used to construct config objects (Issue #184).

@@ -37,6 +37,16 @@ assertEquals("lime", cfg.bar());
assertEquals("orange", cfg.baz());
```

<div class="note info">
Copy link
Collaborator

@lviggiano lviggiano Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but it's better to avoid html in markdown. I'll merge and remove the html tags.

Copy link
Collaborator

@lviggiano lviggiano Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake :-), in this case is more than ok! please ignore above comment :)

@lviggiano lviggiano merged commit c337fca into matteobaccan:master Mar 2, 2018
1 check passed
@lviggiano
Copy link
Collaborator

@lviggiano lviggiano commented Mar 2, 2018

@StFS Why a null value is invalid? Is it always true? Maybe I just want that some configuration property to be null. what do you think?

@lviggiano
Copy link
Collaborator

@lviggiano lviggiano commented Mar 2, 2018

@StFS I created a group on Telegram https://t.me/ownerapi if you want to join.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants