Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing to format Key value by method arguments as with DefaultValue #234

Merged
merged 1 commit into from Sep 3, 2019

Conversation

aknopov
Copy link

@aknopov aknopov commented Jun 4, 2018

Hi Luigi, I decided to accelerate a bit my request for parametrizing keys :).

I have to acknowledge that one existing test SyncAutoReloadTest.testAutoReload() fails because "SyncAutoReloadConfig.properties" is not extracted from SyncAutoReloadTest.jar (though I use Gradle for build).
I also mentioned that SystemLoaderTest.merge_pathEnvVariable() fails in Windows (it uses "Path", not "PATH")

Here are the changes

  • Refactored PropertiesInvocationHandler - passing arguments to StrSubstitutor.replace()
  • Allowing either variable expansion or String formatting in StrSubstitutor
  • Added specialized unit test

- Refactored PropertiesInvocationHandler - passing arguments to StrSubstitutor.replace()
- Allowing either variable expansion or String formatting in StrSubstitutor
- Added specialized unit test
@lviggiano lviggiano merged commit a2003f6 into matteobaccan:master Sep 3, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants