Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow property values to contain a '%' character without being a format string #239

Conversation

staycaffeinated
Copy link

@staycaffeinated staycaffeinated commented Jun 14, 2018

When a property value contains a '%' character, it can be mistaken for a format string (under the covers, String.format is called to expand property values). With this fix, if a property value contains a '%' character but is not actually a format string, we return the property value as-is.

@lviggiano
Copy link
Collaborator

@lviggiano lviggiano commented Jun 14, 2018

@2Step Good idea, I will check it asap

@lviggiano lviggiano merged commit cd481d9 into matteobaccan:master Feb 5, 2019
1 check passed
@lviggiano
Copy link
Collaborator

@lviggiano lviggiano commented Feb 5, 2019

Thank you for the patch, and for the patience. (I have been away for long time, sorry)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants