From c4b6cdef9811e281603ad08d372a62725578172c Mon Sep 17 00:00:00 2001 From: Jordi Date: Fri, 23 Feb 2024 13:26:34 +0100 Subject: [PATCH] Remove TODOs comments --- core/lib/config/src/testonly.rs | 2 -- core/lib/protobuf_config/src/chain.rs | 2 -- 2 files changed, 4 deletions(-) diff --git a/core/lib/config/src/testonly.rs b/core/lib/config/src/testonly.rs index b11fcd3f563..02e449c7989 100644 --- a/core/lib/config/src/testonly.rs +++ b/core/lib/config/src/testonly.rs @@ -286,7 +286,6 @@ impl RandomConfig for configs::chain::StateKeeperConfig { virtual_blocks_per_miniblock: g.gen(), upload_witness_inputs_to_gcs: g.gen(), enum_index_migration_chunk_size: g.gen(), - // TODO: this should depend on the mode (Validium or Rollup), but the tests are not adapted yet for this. l1_batch_commit_data_generator_mode: configs::chain::L1BatchCommitDataGeneratorMode::Rollup, } @@ -498,7 +497,6 @@ impl RandomConfig for configs::eth_sender::GasAdjusterConfig { internal_enforced_l1_gas_price: g.gen(), poll_period: g.gen(), max_l1_gas_price: g.gen(), - // TODO: this should depend on the mode (Validium or Rollup), but the tests are not adapted yet for this. l1_gas_per_pubdata_byte: 17, } } diff --git a/core/lib/protobuf_config/src/chain.rs b/core/lib/protobuf_config/src/chain.rs index dbf50b039bd..4927155dda7 100644 --- a/core/lib/protobuf_config/src/chain.rs +++ b/core/lib/protobuf_config/src/chain.rs @@ -159,7 +159,6 @@ impl ProtoRepr for proto::StateKeeper { .transpose() .context("enum_index_migration_chunk_size")?, l1_batch_commit_data_generator_mode: required(&self.fee_model_version) - // TODO: this should depend on the mode (Validium or Rollup), but the tests are not adapted yet for this. .map(|_x| proto::L1BatchCommitDataGeneratorMode::Rollup) .context("l1_batch_commit_data_generator_mode")? .parse(), @@ -199,7 +198,6 @@ impl ProtoRepr for proto::StateKeeper { .enum_index_migration_chunk_size .as_ref() .map(|x| (*x).try_into().unwrap()), - // TODO: this should depend on the mode (Validium or Rollup), but the tests are not adapted yet for this. l1_batch_commit_data_generator_mode: Some( proto::L1BatchCommitDataGeneratorMode::new( &configs::chain::L1BatchCommitDataGeneratorMode::Rollup,