Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed bytecode compression example #1013

Conversation

benceharomi
Copy link
Contributor

@benceharomi benceharomi commented Feb 5, 2024

What ❔

Updated the bytecode compression explanation example, to be valid and working.

In the connecting contracts PR: matter-labs/era-contracts#193 I added a test that checks the bytecode and runs the publishCompressBytecode function with the bytecode from this example.

Why ❔

The previous example was not valid, it could confuse newcomers, because the example had different bytecode compared to what was described.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@StanislavBreadless StanislavBreadless added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit d28d45d Apr 18, 2024
18 checks passed
@StanislavBreadless StanislavBreadless deleted the bh-evm-321-enforce-correct-relatively-optimal-compression-for-bytecodes branch April 18, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants