Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): Start API server after first L1 batch #1026

Merged
merged 17 commits into from
Feb 8, 2024
Merged

feat(api): Start API server after first L1 batch #1026

merged 17 commits into from
Feb 8, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Feb 7, 2024 •
edited
Loading

What ❔

  • Delays the API server start until there's at least one L1 batch present in the node DB.
  • Refactors the VM sandbox so that it's more modular / maintainable.
  • Tests VM-related API server methods.

Why ❔

Fixes API server operation when working on the DB after snapshot recovery.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@slowli
Copy link
Contributor Author

slowli commented Feb 7, 2024

Sorry for combining multiple features into a single PR; it occurred naturally when covering VM-related API methods in tests and debugging related errors. I could try separating this PR into smaller ones (one per each of the 3 items mentioned in "What"?), but I'm not sure it would be worth it.

@slowli slowli marked this pull request as ready for review February 7, 2024 13:24
RomanBrodetski
RomanBrodetski previously approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@RomanBrodetski RomanBrodetski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left some very minor comments

core/lib/zksync_core/src/api_server/execution_sandbox/apply.rs Outdated Show resolved Hide resolved
core/lib/zksync_core/src/api_server/execution_sandbox/apply.rs Show resolved Hide resolved
core/lib/zksync_core/src/api_server/web3/mod.rs Show resolved Hide resolved
core/lib/zksync_core/src/utils/mod.rs Show resolved Hide resolved
@slowli slowli added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit 86e189c Feb 8, 2024
30 checks passed
@slowli slowli deleted the aov-pla-739-test-api-methods-instantiating-vm branch February 8, 2024 13:44
@zksync-era-bot zksync-era-bot mentioned this pull request Feb 8, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 8, 2024
@zksync-era-bot
chore(main): release core 20.6.0 (#1011)
689d38c 
🤖 I have created a release *beep* *boop*
---


##
[20.6.0](core-v20.5.2...core-v20.6.0)
(2024-02-08)


### Features

* **api:** Start API server after first L1 batch
([#1026](#1026))
([86e189c](86e189c))
* **db:** Instrument DB connection lifecycle
([#1027](#1027))
([636fcfd](636fcfd))
* **db:** Soft-remove `storage` table
([#982](#982))
([601f893](601f893))
* **en:** Make state keeper work with pruned data
([#900](#900))
([f1913ae](f1913ae))
* export fee model for the test node
([#1030](#1030))
([d1e4774](d1e4774))
* Time-limit health checks and log them
([#993](#993))
([f3c190d](f3c190d))
* **types:** Added KZG info needed for 4844 blobs
([#894](#894))
([758f487](758f487))


### Bug Fixes

* fix link
([#1007](#1007))
([f1424ce](f1424ce))
* **metrics:** Use latest block for non pos ethereum as safe
([#1022](#1022))
([49ec843](49ec843))
* Revert "preparation for shared bridge migration (server)"
([#1010](#1010))
([d4c984a](d4c984a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deniallugo Deniallugo Deniallugo left review comments

@RomanBrodetski RomanBrodetski RomanBrodetski approved these changes

@popzxc popzxc Awaiting requested review from popzxc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slowli @RomanBrodetski @Deniallugo