Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing the font size causes rendering issues on next restart #334

Closed
nerfologist opened this issue Oct 6, 2016 · 7 comments

Comments

@nerfologist
Copy link

commented Oct 6, 2016

I confirm (by marking "x" in the [ ] below):


Summary

If I increase the font size (CTRL+-), quit the Mattermost Desktop application and restart it, the content will not occupy the entire UI space, but show a wide white (empty) margin on the right and bottom sides.

Steps to reproduce

  • Open the Mattermost desktop application for Linux.
  • Increase the font size using the CTRL-+ shortcut.
  • Exit the application (CTRL+Q).
  • Open the application again.

Please include:

  • Operating System: Linux Mint 17.3 Cinnamon 64bit
  • Mattermost Desktop App version (See Help > Version Number): 3.4.0 (also present in 3.4.1)
  • Mattermost Server version (See Mattermost Menu > About Mattermost, where Mattermost Menu can be accessed by clicking on three dots next to your profile picture): Mattermost Team Edition 3.4.0 (database: postgres)
  • Clear steps to reproduce the issue: see above

Expected behavior

The UI scales and resizes properly.

Observed behavior

A wide white border is displayed in the right and bottom side of the rendering area. No errors are displayed.

Possible fixes

Workaround: if you reduce the font size again (CTRL -), and restart the application, the problem is fixed.

@yuya-oc

This comment has been minimized.

Copy link
Collaborator

commented Oct 6, 2016

Reproduced on macOS 10.12. Probably it's a bug of electron. electron/electron#7375

zoom

@jasonblais

This comment has been minimized.

Copy link
Member

commented Oct 7, 2016

I saw a note that the Brave browser (built off of Electron) doesn't seem to have the issue,

something to consider looking into?

The zoom in/out functions are a little useless at the moment, at least in their current form

@yuya-oc

This comment has been minimized.

Copy link
Collaborator

commented Oct 8, 2016

As far as reading that, our issue looks a little different. In our case, the zoom level is correct, but only the region is incorrect. Just for reference, I tried brave/electron-prebuilt. But I could not execute the app.
And, their changes seems not to be well-documented, so I feel it's not good choice even if the folk worked.

@jasonblais

This comment has been minimized.

Copy link
Member

commented Oct 22, 2016

Update:

With #240, this issue is partially fixed on master branch -- the zoom level is properly updated if the focus is inside the app window.

The issue continues to reproduce after clicking on the tab bar and attempting to use the zoom shortcuts, for instance.

@siebertm

This comment has been minimized.

Copy link

commented Aug 14, 2017

I was able to reproduce the issue with

OS: Ubuntu 16.04 LTS
MMD: 3.7.0
MMS: 4.0.0 (4.0.2)

Steps to reproduce:

  • delete ~/.config/Mattermost/Preferences
  • Start Mattermost Desktop
  • zoom one step (Ctrl++)
  • quit the app (Ctrl+Q)
  • Start again

=> Problem, as described above.

To fix the problem again, you need quit the app, then remove ~/.config/Mattermost/Preferences.

After that, starting the app again leaves you 'clean-slate' with default zoom factor, but when you change zoom, then restart -> same problem.

I didn't have the issue with MMD < 3.7.0, it wasn't remembering the zoom factor until 3.7.0.

@jasonblais jasonblais modified the milestones: v3.8.0, Unscheduled Aug 14, 2017
@jasonblais

This comment has been minimized.

Copy link
Member

commented Oct 17, 2017

@yuya-oc I moved this issue to the v3.8 milestone after the above repro steps, but wondering if I should move it back to Unscheduled if it's an Electron issue?

@yuya-oc

This comment has been minimized.

Copy link
Collaborator

commented Oct 18, 2017

@jasonblais I'm not sure there is workaround because zoom in/out is strongly depends on Electron's implementation. However investigation is good to know current behavior since Electron was upgraded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.