New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --hidden not working on Linux #571

Merged
merged 2 commits into from Aug 18, 2017

Conversation

Projects
None yet
2 participants
@yuya-oc
Copy link
Collaborator

yuya-oc commented Aug 9, 2017

Before submitting, please confirm you've

Please provide the following information:

Summary
Fix --hidden not working on Linux.

I'm not sure why the problem happens though, it seems that the problem happens by calling BrowserWindow.loadURL() after BrowserWindow.minimize(). So I changed the order of functions.

Tested on Ubuntu 16.04. To make sure, we need to check about Windows as well.

Issue link
#570

Test Cases

  1. Enable "Start app on login".
  2. Logout from the computer, then login again.
  3. Started app should be minimized.

Additional Notes
https://circleci.com/gh/mattermost/desktop/985#artifacts

@jasonblais

This comment has been minimized.

Copy link
Member

jasonblais commented Aug 17, 2017

Tested and works as expected on Windows. Thanks @yuya-oc!

@yuya-oc

This comment has been minimized.

Copy link
Collaborator

yuya-oc commented Aug 18, 2017

Thanks for testing!

@yuya-oc yuya-oc merged commit 6d0e1f7 into master Aug 18, 2017

@yuya-oc yuya-oc deleted the fix-hidden-flag branch Aug 18, 2017

@yuya-oc yuya-oc added this to the v3.8.0 milestone Aug 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment