Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php samples for users documentation #504

Open
wants to merge 6 commits into
base: master
from
Open

Conversation

@gnello
Copy link

gnello commented Mar 23, 2020

Summary

Add PHP samples for users endpoint documentation, based on the community-built PHP Driver.

@hanzei hanzei requested a review from larkox Mar 25, 2020
@hanzei

This comment has been minimized.

Copy link
Member

hanzei commented Mar 25, 2020

/update-branch

@metanerd

This comment has been minimized.

Copy link
Member

metanerd commented Mar 26, 2020

/update-branch

mattermod and others added 2 commits Mar 26, 2020
@metanerd

This comment has been minimized.

Copy link
Member

metanerd commented Mar 26, 2020

Thank you @gnello for your PR! Please ignore the pipeline problems. The problems should be resolved now.

Copy link
Member

larkox left a comment

Looks great. Just a few small changes and concerns.

v4/source/users.yaml Outdated Show resolved Hide resolved
v4/source/users.yaml Outdated Show resolved Hide resolved
v4/source/users.yaml Outdated Show resolved Hide resolved
v4/source/users.yaml Outdated Show resolved Hide resolved
v4/source/users.yaml Outdated Show resolved Hide resolved
v4/source/users.yaml Outdated Show resolved Hide resolved
v4/source/users.yaml Outdated Show resolved Hide resolved
v4/source/users.yaml Outdated Show resolved Hide resolved
@larkox
larkox approved these changes Apr 1, 2020
@larkox

This comment has been minimized.

Copy link
Member

larkox commented Apr 1, 2020

Thank you for the changes! LGTM 🎉

@gnello

This comment has been minimized.

Copy link
Author

gnello commented Apr 1, 2020

I made one last check and corrected $driver->getUserModel into $driver->getUserModel(). Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.