[MM-50458] Desktop App release process #1252
Conversation
devinbinnie
added
1: Dev Review
|
Newest code from devinbinnie has been published to preview environment for Git SHA f72580c |
2 similar comments
|
Newest code from devinbinnie has been published to preview environment for Git SHA f72580c |
|
Newest code from devinbinnie has been published to preview environment for Git SHA f72580c |
|
Newest code from cwarnermm has been published to preview environment for Git SHA cdd3785 |
|
|
||
| ***NOTE**: For the purposes of this document, the letter `X` will refer to the major version number, `Y` wil refer to the minor version number, and `Z` will refer to the patch (dot) version number.* | ||
|
|
||
| ### Before you begin |
There was a problem hiding this comment.
Let's start at H2 for major headings on a dev docs page (##) rather than H3 headings.
| Before starting a new release, you want to make sure you do a few things: | ||
| - Check to make sure that there are no further Story tickets waiting to be merged. You can check JIRA to see if there are anything tickets with the Fix version: `vX.Y Desktop App`. If there are, you'll want to wait until those have been merged. | ||
|
|
||
| - If you work off of a for of the `mattermost/desktop` repo, make sure your local master branch is up to date: |
There was a problem hiding this comment.
| - If you work off of a for of the `mattermost/desktop` repo, make sure your local master branch is up to date: | |
| - If you work off of the `mattermost/desktop` repository, make sure your local master branch is up to date: |
There was a problem hiding this comment.
Sorry, that should say "a fork of" which is the important part here. I'll manually fix this one.
| git checkout master && git fetch --all && git merge upstream/master` | ||
| ``` | ||
|
|
||
| ### Starting a new release |
There was a problem hiding this comment.
Please avoid gerund verb constructions (-ing) in titles
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
|
Newest code from devinbinnie has been published to preview environment for Git SHA a0679b9 |
|
Newest code from devinbinnie has been published to preview environment for Git SHA 6a37a40 |
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
|
Newest code from devinbinnie has been published to preview environment for Git SHA 3cee15a |
|
Newest code from devinbinnie has been published to preview environment for Git SHA 6b9712c |
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
|
Newest code from devinbinnie has been published to preview environment for Git SHA 249b05a |
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
|
Newest code from devinbinnie has been published to preview environment for Git SHA 2d4f895 |
|
Newest code from devinbinnie has been published to preview environment for Git SHA c8f3e66 |
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
|
Newest code from devinbinnie has been published to preview environment for Git SHA 96af076 |
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
|
Newest code from devinbinnie has been published to preview environment for Git SHA 0285cb9 |
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
|
Newest code from devinbinnie has been published to preview environment for Git SHA f083628 |
|
Newest code from devinbinnie has been published to preview environment for Git SHA 25ffb52 |
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
|
Newest code from devinbinnie has been published to preview environment for Git SHA 6a0d26d |
|
Newest code from devinbinnie has been published to preview environment for Git SHA 7daf3b9 |
|
Newest code from devinbinnie has been published to preview environment for Git SHA 2fb3139 |
|
Newest code from devinbinnie has been published to preview environment for Git SHA cfb9d88 |
There was a problem hiding this comment.
Thanks @devinbinnie! Instructions LGTM 👍
This process looks like a good candidate for a playbook we can run in the Release: Desktop channel.
| If the app is **approved** by App Review, you will get an email from App Store Connect saying "Your submission was accepted". From there, you can go back and release the app once the final release has been cut. | ||
|
|
||
| If the app is **rejected** by App Review, you will get an email from App Store Connect saying "We noticed an issue with your submission". At that point, you'll need to log back into App Store Connect and review their comments. Make the necessary changes and you can follow the same process as above to re-submit for review until the app has been approved. |
There was a problem hiding this comment.
How long do they usually take for an answer?
There was a problem hiding this comment.
@devinbinnie - friendly bump on Maria's question.
There was a problem hiding this comment.
Sorry - missed this :D
Usually about 24 hours is their turnaround time, depends on the time of day. I'll add a note in here about that.
| @@ -0,0 +1,117 @@ | |||
| --- | |||
| title: Desktop Release Process | |||
There was a problem hiding this comment.
- If you'd like, feel free to add steps from this doc to the existing Playbook we have https://community.mattermost.com/playbooks/playbooks/h3a39biacpnuim7ufmwiuuoxfo/outline.
- I can also add a link to this page from the Handbook release process page https://handbook.mattermost.com/operations/research-and-development/product/release-process/desktop-release.
There was a problem hiding this comment.
@devinbinnie - friendly bump on Amy's feedback.
There was a problem hiding this comment.
Missed this as well 😅
I can have a look at the playbook and make sure these line up as well :)
A link to this page would definitely be helpful.
|
Newest code from hanzei has been published to preview environment for Git SHA e10a5f8 |
|
Newest code from devinbinnie has been published to preview environment for Git SHA e4a1591 |
|
Newest code from devinbinnie has been published to preview environment for Git SHA fb21118 |
Summary
This contains a release process document for the Desktop App, outlining how to perform the release including the App Store work.
Ticket Link
https://mattermost.atlassian.net/browse/MM-50458