Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update company-agreements.md #60

Merged
merged 2 commits into from Mar 14, 2020
Merged

Conversation

amynicol1985
Copy link
Contributor

@amynicol1985 amynicol1985 commented Mar 4, 2020

Summary

@it33
Copy link
Contributor

it33 commented Mar 5, 2020

@jasonblais propose we have something in guidelines for approval on certain pages in handbook, e.g. CEO approval on any changes to signing authority (this PR).

@jasonblais
Copy link
Collaborator

jasonblais commented Mar 5, 2020

@it33 Agree. I actually started a PR (still work in progress) to gather approved reviewers and permissions. Will continue to expand it: #54

(Also working with HR to pull people's GitHub handles so we can more easily tag people in handbook PRs as needed. Potentially via BambooHR)

@jasonblais
Copy link
Collaborator

jasonblais commented Mar 11, 2020

@amynicol1985 has Aneal reviewed and signed off on the proposed changes here?

@amynicol1985
Copy link
Contributor Author

amynicol1985 commented Mar 13, 2020

@amynicol1985 has Aneal reviewed and signed off on the proposed changes here?

@jasonblais - I don't believe so. How do I go about getting this done?

@jasonblais
Copy link
Collaborator

jasonblais commented Mar 13, 2020

@amynicol1985 for now, you can ping Aneal directly on community.mattermost.com. I am working with HR on getting everyone's GitHub handles added to the Mattermost org, so you can easily request their reviews in pull requests, but we're not there yet

@it33
Copy link
Contributor

it33 commented Mar 13, 2020

Let's just remove "Investor quarterly reporting requests" and the other changes on amounts are fine. Let's do the MVC and merge this.

The problem with "Investor quarterly reporting requests" is that it's both really specific to quarterly reports an yet really broad to "reporting requests" and we can iterate on that later. It's not a big deal, we've probably spent more time discussing the topic than the time it would have saved routing to Aneal vs. Ian, where as the change from $5K to $50K is a big change.

This is a good first PR on agreements. Let's count it as a win and strong iteration. Let's get excited about iterating more.

@jasonblais
Copy link
Collaborator

jasonblais commented Mar 14, 2020

Thanks Ian, removed, merging

@jasonblais jasonblais added the 3: Reviews Complete label Mar 14, 2020
@jasonblais jasonblais merged commit eb8c39d into mattermost:0.2.1 Mar 14, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants