From 057acba97e7269fa1fdce6bb10c0a84387b478d4 Mon Sep 17 00:00:00 2001 From: Cyrus Cheung Date: Sun, 7 Apr 2024 19:29:49 -0700 Subject: [PATCH 1/2] validated issueTitle by removing leading/trailing space --- webapp/src/components/modals/create_issue/create_issue.jsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/webapp/src/components/modals/create_issue/create_issue.jsx b/webapp/src/components/modals/create_issue/create_issue.jsx index 1f8d565f1..8aa670278 100644 --- a/webapp/src/components/modals/create_issue/create_issue.jsx +++ b/webapp/src/components/modals/create_issue/create_issue.jsx @@ -61,9 +61,10 @@ export default class CreateIssueModal extends PureComponent { e.preventDefault(); } - if (!this.validator.validate() || !this.state.issueTitle) { + const isValidTitle = this.state.issueTitle.trim().length !== 0; + if (!this.validator.validate() || !isValidTitle) { this.setState({ - issueTitleValid: Boolean(this.state.issueTitle), + issueTitleValid: Boolean(isValidTitle), showErrors: true, }); return; From c6a0d008d609fd88b8dc5bd1930dd64341c4531b Mon Sep 17 00:00:00 2001 From: Cyrus Cheung Date: Wed, 10 Apr 2024 12:19:36 -0700 Subject: [PATCH 2/2] removed redundant bool type casting --- webapp/src/components/modals/create_issue/create_issue.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapp/src/components/modals/create_issue/create_issue.jsx b/webapp/src/components/modals/create_issue/create_issue.jsx index 8aa670278..25354955a 100644 --- a/webapp/src/components/modals/create_issue/create_issue.jsx +++ b/webapp/src/components/modals/create_issue/create_issue.jsx @@ -64,7 +64,7 @@ export default class CreateIssueModal extends PureComponent { const isValidTitle = this.state.issueTitle.trim().length !== 0; if (!this.validator.validate() || !isValidTitle) { this.setState({ - issueTitleValid: Boolean(isValidTitle), + issueTitleValid: isValidTitle, showErrors: true, }); return;