dist: build linux/darwin arm64 targets #822
Conversation
| @@ -587,7 +587,7 @@ func (p *Plugin) hasPermissionToManageSubscription(instanceID types.ID, userID, | |||
|
|
|||
| switch cfg.RolesAllowedToEditJiraSubscriptions { | |||
| case "team_admin": | |||
| if !p.API.HasPermissionToChannel(userID, channelID, model.PERMISSION_MANAGE_TEAM) { | |||
| if !p.API.HasPermissionToChannel(userID, channelID, model.PermissionManageTeam) { | |||
There was a problem hiding this comment.
I wonder if this should be HasPermissionToTeam or if this still works like this
There was a problem hiding this comment.
maybe @hanzei can comment this
There was a problem hiding this comment.
I don't think the semantics for permissions have changed. Also, the server does fall back to HasPermissionToTeam: https://github.com/mattermost/mattermost-server/blob/21639f9c8730b2f49ee52322acd3acdbf64ac6d9/app/authorization.go#L190
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
==========================================
- Coverage 34.93% 34.89% -0.04%
==========================================
Files 52 52
Lines 5945 5943 -2
==========================================
- Hits 2077 2074 -3
+ Misses 3659 3658 -1
- Partials 209 211 +2
Continue to review full report at Codecov.
|
| @@ -587,7 +587,7 @@ func (p *Plugin) hasPermissionToManageSubscription(instanceID types.ID, userID, | |||
|
|
|||
| switch cfg.RolesAllowedToEditJiraSubscriptions { | |||
| case "team_admin": | |||
| if !p.API.HasPermissionToChannel(userID, channelID, model.PERMISSION_MANAGE_TEAM) { | |||
| if !p.API.HasPermissionToChannel(userID, channelID, model.PermissionManageTeam) { | |||
There was a problem hiding this comment.
I don't think the semantics for permissions have changed. Also, the server does fall back to HasPermissionToTeam: https://github.com/mattermost/mattermost-server/blob/21639f9c8730b2f49ee52322acd3acdbf64ac6d9/app/authorization.go#L190
hanzei
added
the
4: Reviews Complete
Summary
Adding the linux/darwin arm64 targets, we start building arm64 for the server and will start adding the targets for the plugins for the ones we prepackage in the build
related to: mattermost/mattermost#18491
Ticket Link
related to https://mattermost.atlassian.net/browse/DOPS-633