Refactor zoom package #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
commented
Jun 13, 2019
| func closeBody(r *http.Response) { | ||
| if r.Body != nil { | ||
| ioutil.ReadAll(r.Body) | ||
| r.Body.Close() |
There was a problem hiding this comment.
I don't know if this method is needed.
There was a problem hiding this comment.
Yes, responses for requests open by a client need to be closed, explicitly, even for a Keep-alive (the http stack manages the connections itself)
levb
approved these changes
Jun 13, 2019
| func closeBody(r *http.Response) { | ||
| if r.Body != nil { | ||
| ioutil.ReadAll(r.Body) | ||
| r.Body.Close() |
There was a problem hiding this comment.
Yes, responses for requests open by a client need to be closed, explicitly, even for a Keep-alive (the http stack manages the connections itself)
crspeller
approved these changes
Jun 13, 2019
hanzei
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #25