This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
MM-21726 Add theme type and function to set theme defaults #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinbinnie
approved these changes
Jan 16, 2020
|
What are the corresponding changes on the web app for this? The |
hmhealey
approved these changes
Jan 17, 2020
amyblais
added
the
CherryPick/Approved
saturninoabril
approved these changes
Jan 21, 2020
saturninoabril
added
4: Reviews Complete
mattermod
added
CherryPick/Done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This will be used in an upcoming webapp PR to fix the bug in the ticket. Essentially we need to make sure all the theme properties are set before applying themes.
Ticket Link
https://mattermost.atlassian.net/browse/MM-21726