Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on a file:// link does not work (usecase: synced files with several users) #12042

Closed
biva opened this issue Sep 4, 2019 · 3 comments
Closed

Comments

@biva
Copy link

@biva biva commented Sep 4, 2019

Summary

Clicking on a file:// link does not work for local folders.

I'm not sure if I should post this here or on https://github.com/mattermost/desktop

Steps to reproduce

  • Create a link to a local file [My local file](C:\Docs\locafile.docx)
  • Click on the link

Expected behavior

The file (or the folder) should be opened

Observed behavior (that appears unintentional)

  • On Desktop, it doesn't do anything
  • On Firefox, it opens a blank page

Possible fixes

This issue has been reported several times: mattermost/desktop#579 , mattermost/desktop#772 , mattermost/desktop#821
Apparently, this is intentional as explained by @yuya-oc because:

  • Accepting local resources would allow to execute programs via malicious link
  • There is no situation where an user would want to share their local files without attached files.

In my usecase, we use Nextcloud to sync files within our group. And we have the same letter and path for local files. This is why we often share the file path instead of the file itself, to save data. We would love to be able to open the link directly.

@amyblais

This comment has been minimized.

Copy link
Member

@amyblais amyblais commented Sep 4, 2019

Thanks, appreciate your feedback @biva,

Would you like to contribute this in the feature idea forum so it can be discussed, upvoted and considered for a help wanted ticket?

Please include a link back to this GitHub issue. If you're interested in implementing, please say so and we'll prioritize the review.

@amyblais

This comment has been minimized.

Copy link
Member

@amyblais amyblais commented Sep 4, 2019

Thank you! Closing this as this can be tracked via the feature request,

@amyblais amyblais closed this Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.