Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Help Wanted] [PLT-7824] Slack-compatible webhooks: Support mentions with <@userid> and <!here> #7615

Closed
esethna opened this issue Oct 12, 2017 · 1 comment
Labels
Difficulty/2:Medium Medium ticket Tech/Go Server

Comments

@esethna
Copy link
Contributor

esethna commented Oct 12, 2017

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide, specifically for machine setup and for developer workflow.


Notes: Jira ticket

Slack integrations support

  • mentioning users with <@userid>
  • special mentions such as <!channel> and <!here>

Slack is removing usernames ([see changelog|https://api.slack.com/changelog/2017-09-the-one-about-usernames]) and is pushing people to mention users with the userid instead.

Hence, to maintain Slack-compatibility, we should add support for integrations to

  1. mention users with <@userid>

Example:

a) Make a webhook post with the following payload: {"text": "hey <@beqkgo4wzbn98kjzjgc1p5n91o>"}
b) When the message is posted, "<@beqkgo4wzbn98kjzjgc1p5n91o>" should render as a user mention, such as:

image

  1. use special mentions for at-channel, at-here and at-all via "<!channel>", "<!here>" and "<!all>", respectively.

Example:

a) Make a webhook post with the following payload: {"text": "hey <!here>"}
b) When the message is posted, "!here@beqkgo4wzbn98kjzjgc1p5n91o" should render as "@here":

image

NOTE: This change should be on the server-side, and only affect webhooks and custom slash commands.

@jasonblais jasonblais added the Difficulty/2:Medium Medium ticket label Oct 12, 2017
@jasonblais jasonblais changed the title [Help Wanted] [PLT-7824] Slack-compatible webhooks: Support mentions with and [Help Wanted] [PLT-7824] Slack-compatible webhooks: Support mentions with <@userid> and <!here> Oct 12, 2017
@jasonblais jasonblais added the Tech/Go Server label Oct 12, 2017
@yeoji
Copy link
Contributor

yeoji commented Oct 29, 2017

Hi, I gave this a go and have opened a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/2:Medium Medium ticket Tech/Go Server
Projects
None yet
Development

No branches or pull requests

3 participants