Add props to plugin manifest #10124
Merged
Add props to plugin manifest #10124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
added
2: Dev Review
levb
approved these changes
Jan 20, 2019
There was a problem hiding this comment.
We use Props elsewhere for similar purpose, so I think the naming is consistent.
While I generally support this PR, I am 1/5 that a more flexible alternative would be to store the full manifest text "as is" in addition to unmarshaling/normalizing the known fields out of it. This way plugin developers can include custom data anywhere in the manifest, and access it later.
jasonblais
reviewed
Jan 23, 2019
jasonblais
approved these changes
Jan 23, 2019
jasonblais
added
4: Reviews Complete
|
Thanks! Ready to merge |
|
@levb Lets keep this idea deferred until we have a use case that we can support with |
amyblais
added
Changelog/Not Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows plugin to include arbitrary data in the manifest. This data can be used by other plugin. My use case is the update plugin (https://github.com/hanzei/plugin-update/).
See https://github.com/hanzei/mattermost-plugin-sample/blob/master/plugin.json for an example how this looks like.
1/5 on the naming.