Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-19445 - Added version information to plugin diagnostics data #13408

Merged
merged 31 commits into from Jan 16, 2020
Merged

MM-19445 - Added version information to plugin diagnostics data #13408

merged 31 commits into from Jan 16, 2020

Conversation

marianunez
Copy link
Member

@marianunez marianunez commented Dec 17, 2019 •
edited

Summary

Within the config_plugin data structure:

  • Included entries to track version number for whitelisted plugins under version-[pluginName]
  • Added new entry for EnableRemoteMarketplace setting.
  • Added webex to the list of whitelisted plugins for enabled and version number.

Ticket Link

MM-19445

alifarooq0 and others added 8 commits November 18, 2019 22:16
@alifarooq0
MM-19609 - Add new prepackage configuration settings (#13062)
b608523
@iomodo @alifarooq0
Add signatures to the prepackaged plugins (#13138)
128e447
@alifarooq0
Merge remote-tracking branch 'origin/master' into rework_prepackaged_…
c480860 
…plugins_2
@lieut-data
Merge remote-tracking branch 'origin/master' into rework_prepackaged_…
49e3394 
…plugins_2
@marianunez
Merge remote-tracking branch 'origin/master' into mm-19606-feature-re…
f5fff09 
…work-prepackaged-plugins
@alifarooq0 @marianunez
MM-19612 - Support querying local plugin marketplace when upst… (#13250)
5a33707 
* MM-19612 - Support querying local plugin marketplace when upstream unavailable or disabled

* Update translations file

* Fixed comment

* Updated to check EnableRemoteMarketplace setting and LocalOnly to get marketplace plugins

* Fixed unit tests

* Tests cleanup code

* Removed unused error message

* Updated tests
@marianunez @hanzei
MM-19614- Updated Marketplace Service error id (#13388)
55d739d
@marianunez
Added version information to plugin diagnostics data
ff82954
@marianunez marianunez added 2: Dev Review Requires review by a developer 1: PM Review Requires review by a product manager labels Dec 17, 2019
@marianunez marianunez added this to the v5.20.0 milestone Dec 17, 2019
@marianunez
Copy link
Member Author

marianunez commented Dec 17, 2019 •
edited

@aaronrothschild @jasonblais data structure and entry name (enable-[pluginName]) open to change for what would be best for reporting purposes in segment.

If possible, I would suggest to changing the entry name to just the [pluginName] leaving room to expand that for future data points as needed.

@aaronrothschild
Copy link
Contributor

@aaronrothschild @jasonblais data structure and entry name (enable-[pluginName]) open to change for what would be best for reporting purposes in segment.

If possible, I would suggest to changing the entry name to just the [pluginName] leaving room to expand that for future data points as needed.

Thanks Maria! I'll leave it to @jasonblais regarding the data structure that he's looking into. Looks good otherwise, looking forward to seeing the data! :)

hanzei
hanzei requested changes Dec 17, 2019
View reviewed changes
app/diagnostics.go Outdated Show resolved Hide resolved
app/diagnostics.go Outdated Show resolved Hide resolved
marianunez and others added 3 commits December 17, 2019 11:56
@marianunez
Merge remote-tracking branch 'origin/master' into mm-19606-feature-re…
474c932 
…work-prepackaged-plugins
@lieut-data
Merge remote-tracking branch 'origin/master' into mm-19606-feature-re…
5aa5aa3 
…work-prepackaged-plugins
@iomodo @lieut-data
[MM-19610] Consume prepackaged plugins (#13005)
0d2e3c5 
* consume prepackaged plugins into memory

* missing i18n

* remove spurious .gitignore changes

* return on failure to install prepackged plugins

* cleanup

* s/plugins/availablePlugins

* whitespace

* don't return extractDir when not needed

* s/plug/plugin

* error on icon, cleanup

* update armored version of testplugin signature

* honour AutomaticPrepackagedPlugins

* document getPrepackagedPlugin
lieut-data
lieut-data requested changes Dec 18, 2019
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marianunez! Two thoughts below re: how we want to organize and structure the data for upstream processing.

app/diagnostics.go Outdated Show resolved Hide resolved
app/diagnostics.go Outdated Show resolved Hide resolved
marianunez and others added 2 commits December 20, 2019 13:06
@marianunez
MM-19613 - Include prepackaged plugins in marketplace results (#13433)
1264fbe 
* Added prepackaged plugins to marketplace results

* PR Feedback

* PR Feedback

* Update error where definition

* Removing unnecessary var declaration

* Updated comments
@alifarooq0
MM-21263 - Use EnableRemoteMarketplace in marketplace install… (#13438)
2c3e08f 
* MM-21263 - Use EnableRemoteMarketplace in marketplace install endpoint

* Call updateConfig before calling NewServer in TestHelper

* Added translations

* PR feedback

* Translations

* Feedback

* s/helpers.go/download.go

* Converging env.PrepackagedPlugins
@marianunez
Copy link
Member Author

I've updated this PR to the changes we agreed on keeping the version numbers in their separate entries for each plugin. It is now ready for re-review. 👍

@hanzei
Copy link
Contributor

hanzei commented Jan 13, 2020

@aaronrothschild Heads up that https://docs.mattermost.com/administration/telemetry.html needs an update after this PR is merged.

hanzei
hanzei requested changes Jan 13, 2020
View reviewed changes
app/diagnostics.go Show resolved Hide resolved
app/diagnostics.go Show resolved Hide resolved
app/diagnostics.go Show resolved Hide resolved
app/diagnostics.go Show resolved Hide resolved
hanzei
hanzei approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine. I'm leaving the decision about the set of plugins to send diagnostics for to @aaronrothschild

@hanzei hanzei removed the 2: Dev Review Requires review by a developer label Jan 14, 2020
@lieut-data lieut-data added the Tests/Not Needed New release tests not required label Jan 14, 2020
@lieut-data
Copy link
Member

@aaronrothschild to confirm subset and help with post-merge testing.

@marianunez marianunez changed the base branch from mm-19606-feature-rework-prepackaged-plugins to master January 16, 2020 02:59
@marianunez
Copy link
Member Author

@aaronrothschild I will be merging this to meet v5.20 feature complete. Please review the list of plugins and let me know if there is any change to be done post-merge.

@marianunez marianunez merged commit c21ea5b into master Jan 16, 2020
@marianunez marianunez deleted the MM-19445 branch January 16, 2020 13:46
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonblais jasonblais jasonblais left review comments

@lieut-data lieut-data lieut-data approved these changes

@hanzei hanzei hanzei approved these changes

@aaronrothschild aaronrothschild Awaiting requested review from aaronrothschild

Assignees

@aaronrothschild aaronrothschild

Labels
1: PM Review Requires review by a product manager Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed New release tests not required
Projects
None yet
Milestone
v5.20.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@marianunez @aaronrothschild @hanzei @lieut-data @jasonblais @amyblais @alifarooq0 @iomodo