[MM-21123] Add Labels to upstream Marketplace response

[hanzei]

Summary

When fetching the Plugins from upstream Marketplace include also the fetched labels.

Ticket Link

https://mattermost.atlassian.net/browse/MM-21123
https://mattermost.atlassian.net/browse/MM-21611

Related Pull Requests

• Has Marketplace changes: [MM-21123] Add official label to all plugins mattermost-marketplace#31

[hanzei]

@lieut-data Re-requesting your review also I also included the changes needed for https://mattermost.atlassian.net/browse/MM-21611

[marianunez]

This should be added only if the EnableRemoteMarketplace is enabled though. However, this setting is being introduced in this PR: #13449

What should be the best approach here to synch this? After you merge this maybe I can update the other PR to add the condition there

[hanzei]

Well, let's see what PR goes in first 😉 When can update the other one then.

[hanzei]

@marianunez I've updated the #13449 in 1035471. I hope this was fine to you.

[hanzei]

Similar to mattermost/mattermost-marketplace#31 (comment), I also added a commit here in 6376e83

[alifarooq0]

Looks good, just one comment about internationalization for https://github.com/mattermost/mattermost-server/pull/13425/files#diff-d07092579ced8908e9521d5930e3328aR507

[prapti]

@hanzei Executing curl localhost:8085/api/v1/health does not return info about the "OFFICIAL" tag. Was this change supposed to go in with this PR? The rest looks good.
The following is what gets returned for the curl command:

>curl localhost:8085/api/v1/health
>{"status":"pass","version":"1","releaseID":"","details":{"buildInfo":{"buildHash":"b47d3173b87aac83a20020ea0a13e5c1c71a83a8","buildHashShort":"b47d317"}},"description":"The stateless HTTP service backing the Mattermost marketplace"}

[lieut-data]

@prapti, did you mean to test against the health endpoint? That will just return information about the marketplace server itself.

It looks like you have the right commits, but you should query /api/v1/plugins instead.

[prapti]

@lieut-data I was testing based on the steps mentioned in this ticket. /api/v1/plugins does return proper info about the OFFICIAL tag.
@hanzei was the test step meant to query against /api/v1/plugins instead?

[hanzei]

Good catch @prapti 👍

I've updated the QA steps in the ticket.

[prapti]

Tested and verified on local instance that OFFICIAL and LOCAL tags show up for official Marketplace plugins and manually uploaded ones appropriately.
Some of the concerns regarding showing LOCAL plugins only when Enable Remote Marketplace is enabled will be tested during feature testing.