Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-21071 #13564

Merged
merged 6 commits into from Jan 21, 2020
Merged

MM-21071 #13564

merged 6 commits into from Jan 21, 2020

Conversation

wiggin77
Copy link
Member

@wiggin77 wiggin77 commented Jan 4, 2020

Summary

This pull request replaces the server endpoint POST server_busy/clear with a more RESTful idiomatic DELETE server_busy.

Behaviour of the endpoint remains unchanged.

Ticket Link

https://mattermost.atlassian.net/browse/MM-21071

@wiggin77
Merge pull request #1 from mattermost/master
00ac14c 
Rebase from upstream
@wiggin77
Merge remote-tracking branch 'upstream/master'
c88dd5e
@wiggin77
MM-21071
821a73b 
* replace endpoint `POST server_busy/clear` with the more RESTful idiomatic `DELETE server_busy` to clear the busy flag
@hanzei hanzei added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Jan 7, 2020
@hanzei hanzei added this to the v5.20.0 milestone Jan 7, 2020
@jwilander
Copy link
Member

/update-branch

@hanzei hanzei removed the 2: Dev Review Requires review by a developer label Jan 13, 2020
@amyblais amyblais modified the milestone: v5.20.0 Jan 17, 2020
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Jan 17, 2020
@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process) and removed 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Jan 21, 2020
@saturninoabril
Copy link
Member

/update-branch

@saturninoabril saturninoabril added the AutoMerge Used by Mattermod to merge PR automatically label Jan 21, 2020
@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@hanzei
Copy link
Contributor

hanzei commented Jan 21, 2020

/update-branch

@hanzei hanzei removed the AutoMerge Used by Mattermod to merge PR automatically label Jan 21, 2020
@hanzei hanzei self-assigned this Jan 21, 2020
@hanzei hanzei changed the title MM 21071 - rename endpoint POST server_busy/clear to DELETE server_busy MM-21071 Jan 21, 2020
@hanzei hanzei merged commit 173c4ab into mattermost:master Jan 21, 2020
@mattermost-build mattermost-build mentioned this pull request Jan 21, 2020
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jan 21, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 21, 2020
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Needed Requires documentation and removed Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Feb 11, 2020
@amyblais amyblais assigned wiersgallak and unassigned hanzei and wiersgallak Feb 11, 2020
@amyblais amyblais added Docs/Done Required documentation has been written and removed Docs/Needed Requires documentation labels Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reflog reflog reflog approved these changes

@jwilander jwilander jwilander approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

@hanzei hanzei hanzei approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Done Required documentation has been written QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process)
Projects
None yet
Milestone
v5.20.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@wiggin77 @jwilander @saturninoabril @mattermod @hanzei @reflog @amyblais @wiersgallak