Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-47137] P2 // Fix active_user_count increasing without the users themselves logging in #21437

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[MM-47137] P2 // Fix active_user_count increasing without the users themselves logging in #21437

wants to merge 7 commits into from

Conversation

plant99
Copy link
Contributor

@plant99 plant99 commented Oct 18, 2022 •
edited

Summary

active_user_count metric was being counted wrongly, when a user with no activity was deleted. This PR introduces a flag called updateLastActivityAt which conditionally updates status.lastActivityAt.

Ticket Link

https://mattermost.atlassian.net/browse/MM-47137

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 18, 2022
@plant99 plant99 requested a review from mkraft October 18, 2022 08:47
@plant99 plant99 changed the title [MM-47137] Fix active_user_count increasing without the users themselves logging in [MM-47137] P3 // Fix active_user_count increasing without the users themselves logging in Oct 20, 2022
@plant99 plant99 changed the title [MM-47137] P3 // Fix active_user_count increasing without the users themselves logging in [MM-47137] P2 // Fix active_user_count increasing without the users themselves logging in Oct 20, 2022
BenCookie95
BenCookie95 previously approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@BenCookie95 BenCookie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@plant99 plant99 added the 2: Dev Review Requires review by a developer label Nov 28, 2022
mkraft
mkraft previously approved these changes Jan 16, 2023
View reviewed changes
@plant99 plant99 added 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review and removed 2: Dev Review Requires review by a developer labels Jan 17, 2023
@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@furqanmlk
Copy link
Contributor

/update-branch

@furqanmlk
Copy link
Contributor

/e2e-test

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@furqanmlk
Copy link
Contributor

/e2e-test

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@calebroseland calebroseland dismissed stale reviews from mkraft and BenCookie95 via 8ed8ae0 April 7, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furqanmlk furqanmlk furqanmlk approved these changes

@mkraft mkraft mkraft left review comments

@BenCookie95 BenCookie95 BenCookie95 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review Lifecycle/1:stale release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@plant99 @mattermost-build @furqanmlk @mkraft @BenCookie95 @mm-cloud-bot