[MM-18146] Order tooltip for reactions on web by who recently reacted with those emoji #3671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
added
1: PM Review
esethna
changed the title
|
The code looks great, but I want to double check the ordering with @esethna. Based on the ticket, I would've expected that the list starts with the user who reacted first, but this has them appearing last. |
esethna
requested changes
Sep 20, 2019
@hmhealey you are correct, good catch. @abdusabri can we please reverse the order so the first person who reacted with the emoji appears first in the tooltip, and the most recent person appears last. Apologies the ticket should have been more clear.
bradjcoughlin
approved these changes
Sep 22, 2019
|
Mattermost test server updated with git commit Access here: https://mattermost-webapp-pr-3671.test.mattermost.cloud |
hmhealey
approved these changes
Sep 23, 2019
Awesome, thanks for changing that. I'll bump Eric for a re-review so we can get this in
esethna
approved these changes
Sep 23, 2019
|
Thanks @abdusabri, nice work! |
saturninoabril
reviewed
Sep 24, 2019
| users, | ||
| ['You', 'username_2', 'username_3'] | ||
| ); | ||
| }); |
saturninoabril
added
4: Reviews Complete
|
Test server destroyed |
jwilander
pushed a commit
that referenced
this issue
Sep 24, 2019
… with those emoji (#3671) * Order tooltip for reactions by who recently reacted * Improve sorting by recency test for reactions * Order reactions by who reacted first (instead of who reacted last)
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this issue
Oct 3, 2019
… with those emoji (mattermost#3671) * Order tooltip for reactions by who recently reacted * Improve sorting by recency test for reactions * Order reactions by who reacted first (instead of who reacted last)
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this issue
Oct 3, 2019
… with those emoji (mattermost#3671) * Order tooltip for reactions by who recently reacted * Improve sorting by recency test for reactions * Order reactions by who reacted first (instead of who reacted last)
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this issue
Oct 3, 2019
… with those emoji (mattermost#3671) * Order tooltip for reactions by who recently reacted * Improve sorting by recency test for reactions * Order reactions by who reacted first (instead of who reacted last)
amyblais
added
Changelog/Not Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Summary
In the tooltip of an emoji reaction to a post, the users are ordered by
recency (who reacted most recently)who reacted first, not alphabetically. And if the logged-in user has reacted, "You" - or its localized equivalent - will precede the other users in the tooltip (even if they reactedafterbefore the logged-in user).Ticket Link
Fixes mattermost/mattermost-server#12186