New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-18146] Order tooltip for reactions on web by who recently reacted with those emoji #3671
[MM-18146] Order tooltip for reactions on web by who recently reacted with those emoji #3671
Conversation
The code looks great, but I want to double check the ordering with @esethna. Based on the ticket, I would've expected that the list starts with the user who reacted first, but this has them appearing last. |
@hmhealey you are correct, good catch. @abdusabri can we please reverse the order so the first person who reacted with the emoji appears first in the tooltip, and the most recent person appears last. Apologies the ticket should have been more clear.
Mattermost test server updated with git commit Access here: https://mattermost-webapp-pr-3671.test.mattermost.cloud |
Awesome, thanks for changing that. I'll bump Eric for a re-review so we can get this in
Thanks @abdusabri, nice work! |
users, | ||
['You', 'username_2', 'username_3'] | ||
); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test server destroyed |
… with those emoji (#3671) * Order tooltip for reactions by who recently reacted * Improve sorting by recency test for reactions * Order reactions by who reacted first (instead of who reacted last)
… with those emoji (mattermost#3671) * Order tooltip for reactions by who recently reacted * Improve sorting by recency test for reactions * Order reactions by who reacted first (instead of who reacted last)
… with those emoji (mattermost#3671) * Order tooltip for reactions by who recently reacted * Improve sorting by recency test for reactions * Order reactions by who reacted first (instead of who reacted last)
… with those emoji (mattermost#3671) * Order tooltip for reactions by who recently reacted * Improve sorting by recency test for reactions * Order reactions by who reacted first (instead of who reacted last)
Summary
In the tooltip of an emoji reaction to a post, the users are ordered by
recency (who reacted most recently)who reacted first, not alphabetically. And if the logged-in user has reacted, "You" - or its localized equivalent - will precede the other users in the tooltip (even if they reactedafterbefore the logged-in user).Ticket Link
Fixes mattermost/mattermost-server#12186