Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[MM-18146] Order tooltip for reactions on web by who recently reacted with those emoji #3671
Conversation
|
Nice work @abdusabri! |
esethna
changed the title
This comment has been minimized.
This comment has been minimized.
|
The code looks great, but I want to double check the ordering with @esethna. Based on the ticket, I would've expected that the list starts with the user who reacted first, but this has them appearing last. |
|
@hmhealey you are correct, good catch. @abdusabri can we please reverse the order so the first person who reacted with the emoji appears first in the tooltip, and the most recent person appears last. Apologies the ticket should have been more clear. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Mattermost test server updated with git commit Access here: https://mattermost-webapp-pr-3671.test.mattermost.cloud |
|
Awesome, thanks for changing that. I'll bump Eric for a re-review so we can get this in |
This comment has been minimized.
This comment has been minimized.
|
Thanks @abdusabri, nice work! |
| users, | ||
| ['You', 'username_2', 'username_3'] | ||
| ); | ||
| }); |
This comment has been minimized.
This comment has been minimized.
|
Tested and passed. Thanks @abdusabri! |
saturninoabril
added
3: Reviews Complete
and removed
Setup Cloud Test Server
2: QA Review
labels
This comment has been minimized.
This comment has been minimized.
|
Test server destroyed |
saturninoabril
merged commit 307ccc6
into
mattermost:master
… with those emoji (mattermost#3671) * Order tooltip for reactions by who recently reacted * Improve sorting by recency test for reactions * Order reactions by who reacted first (instead of who reacted last)
… with those emoji (mattermost#3671) * Order tooltip for reactions by who recently reacted * Improve sorting by recency test for reactions * Order reactions by who reacted first (instead of who reacted last)
… with those emoji (mattermost#3671) * Order tooltip for reactions by who recently reacted * Improve sorting by recency test for reactions * Order reactions by who reacted first (instead of who reacted last)
… with those emoji (mattermost#3671) * Order tooltip for reactions by who recently reacted * Improve sorting by recency test for reactions * Order reactions by who reacted first (instead of who reacted last)
abdusabri commentedSep 15, 2019
•
edited
Summary
In the tooltip of an emoji reaction to a post, the users are ordered by
recency (who reacted most recently)who reacted first, not alphabetically. And if the logged-in user has reacted, "You" - or its localized equivalent - will precede the other users in the tooltip (even if they reactedafterbefore the logged-in user).Ticket Link
Fixes mattermost/mattermost-server#12186