Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix incorrect link handling of inline MD images #4543
As of MM-12898, inline markdown images open the image preview modal, except if the markdown image itself is a link. e.g.
This PR fixes the following bug:
For a case like
Observed behavior: The image doesn't have a pointer cursor, and doesn't open the preview modal
Expected behavior: The image should have a pointer cursor and open the preview modal
Reason of wrong behavior: just because there is a link (
The bug is not a regression, it is a missed case since the implementation of MM-12898, but was only discovered after MM-15232, MM-18158. The issue can be reproduced on community V5.18 and latest master. The bug is not limited to channel header descriptions or its associated system messages, and can be reproduced in regular chat messages as well.
Error trying doing the automated Cherry picking. Please do this manually