-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-54799] Convert ./components/widgets/menu/menu_header.tsx from Class Component to Function Component #24847
[MM-54799] Convert ./components/widgets/menu/menu_header.tsx from Class Component to Function Component #24847
Conversation
Hello @dipandhali2021, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
E2E tests not automatically triggered, because the PR is not in a mergeable state. Please update the branch with the base branch and resolve outstanding conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this. I hope you had a good experience 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you very much!
/update-branch |
/e2e-test |
Successfully triggered E2E testing! |
Hi @lindy65, I would like to test this PR as a QA. Looking forward to your guidance. |
Hi @Tahanima - thanks for picking up QA on this PR 🎉 Log into the test server above using either of the credentials. Please test functionality around Custom Status (setting a custom status, clearing status, adding emoji icon, etc) accessible from Profile icon top right of the screen in webapp Let me know if you have any questions! |
I've tested the changes in the test server and it looks good to me. Steps
Operating SystemUbuntu 22.04.3 LTS BrowserVersion 118.0.5993.88 Recordingchrome.webmcc: @lindy65 |
Test server destroyed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! |
Summary
This PR converts the MenuHeader component from class based component to functional based component
Ticket Link
Fixes #24763
Screenshots
Release Note