Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-54799] Convert ./components/widgets/menu/menu_header.tsx from Class Component to Function Component #24847

Merged
merged 6 commits into from
Oct 30, 2023
Merged

[MM-54799] Convert ./components/widgets/menu/menu_header.tsx from Class Component to Function Component #24847

merged 6 commits into from
Oct 30, 2023

Conversation

dipandhali2021
Copy link
Contributor

Summary

This PR converts the MenuHeader component from class based component to functional based component

Ticket Link

Fixes #24763

Screenshots

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 9, 2023
@mattermost-build
Copy link
Contributor

Hello @dipandhali2021,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@M-ZubairAhmed M-ZubairAhmed added 2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Oct 10, 2023
@mattermost-build
Copy link
Contributor

E2E tests not automatically triggered, because the PR is not in a mergeable state. Please update the branch with the base branch and resolve outstanding conflicts.

@M-ZubairAhmed M-ZubairAhmed changed the title Converted Menu Header from Class to Function component [MM-54799] Convert ./components/widgets/menu/menu_header.tsx from Class Component to Function Component Oct 10, 2023
M-ZubairAhmed
M-ZubairAhmed approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@M-ZubairAhmed M-ZubairAhmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. I hope you had a good experience 😄

larkox
larkox approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you very much!

@larkox
Copy link
Contributor

larkox commented Oct 16, 2023

/update-branch

@larkox larkox requested a review from lindy65 October 16, 2023 08:36
@larkox larkox added QA-wanted Available for QA review by QA contributors during Hacktoberfest and removed 2: Dev Review Requires review by a developer labels Oct 16, 2023
@lindy65 lindy65 added the Setup Cloud Test Server Setup an on-prem test server label Oct 18, 2023
@larkox
Copy link
Contributor

larkox commented Oct 18, 2023

/e2e-test

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@Tahanima
Copy link

Hi @lindy65, I would like to test this PR as a QA. Looking forward to your guidance.

@lindy65
Copy link
Contributor

lindy65 commented Oct 20, 2023 •
edited

Hi @Tahanima - thanks for picking up QA on this PR 🎉

Log into the test server above using either of the credentials.

Please test functionality around Custom Status (setting a custom status, clearing status, adding emoji icon, etc) accessible from Profile icon top right of the screen in webapp

image

image

Let me know if you have any questions!

@Tahanima
Copy link

I've tested the changes in the test server and it looks good to me.

Steps

  • Log in to the web application using the given credentials (Username: sysadmin, Password: Sys@dmin123)
  • Click on the user avatar and set a custom status.
    • Choose status from a list of suggestions
    • Change expiration time
    • Select emoji
    • Create and select a custom emoji
    • Delete a custom emoji
    • Clear current status
    • Clear recent status
  • Hover on the emoji icon and click on it after setting a custom status to open the 'Set a status' modal.

Operating System

Ubuntu 22.04.3 LTS

Browser

Version 118.0.5993.88

Recording

chrome.webm

cc: @lindy65

@lindy65 lindy65 removed Setup Cloud Test Server Setup an on-prem test server QA-wanted Available for QA review by QA contributors during Hacktoberfest labels Oct 30, 2023
@mm-cloud-bot
Copy link

Test server destroyed

lindy65
lindy65 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dipandhali2021 - looks good 👍

Thanks for QA'ing @Tahanima 🎉

cc @larkox

@lindy65 lindy65 added 4: Reviews Complete All reviewers have approved the pull request QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process) and removed 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review labels Oct 30, 2023
@larkox larkox merged commit 1b706e0 into mattermost:master Oct 30, 2023
15 checks passed
@larkox
Copy link
Contributor

larkox commented Oct 30, 2023

Thank you for the contribution!

@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 30, 2023
@jwilander jwilander added the kind/refactor Categorizes issue or PR as related to refactor of production code. label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkox larkox larkox approved these changes

@lindy65 lindy65 lindy65 approved these changes

@M-ZubairAhmed M-ZubairAhmed M-ZubairAhmed approved these changes

Assignees

@Tahanima Tahanima

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Contributor Docs/Not Needed Does not require documentation Hacktoberfest kind/refactor Categorizes issue or PR as related to refactor of production code. QA/Review Done QA review is completed but other reviews are outstanding (exception to usual process) release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert ./components/widgets/menu/menu_header.tsx from Class Component to Function Component
9 participants
@dipandhali2021 @mattermost-build @larkox @Tahanima @lindy65 @mm-cloud-bot @M-ZubairAhmed @jwilander @amyblais