[MM-56792] Clarify large plugin upload error#26271
[MM-56792] Clarify large plugin upload error#26271hanzei merged 13 commits intomattermost:masterfrom
Conversation
MM-56792: Clarify large plugin upload error
|
Hello @daveseo901, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
|
E2E tests not automatically triggered, because the PR is not in a mergeable state. Please update the branch with the base branch and resolve outstanding conflicts. |
mickmister
left a comment
There was a problem hiding this comment.
Thanks @daveseo901! LGTM 👍
|
/update-branch |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
|
Hey @daveseo901, What do you think about my comments above? #26271 (review) |
|
Hi @hanzei , I added some comments and a question above! |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
|
@daveseo901 Are you still interested in wrapping up the final comments on this PR? I would love to merge it soon. |
@hanzei Yes, I will submit the changes later today. |
|
@larkox Please take another look |
|
/update-branch |
DHaussermann
left a comment
There was a problem hiding this comment.
Tested and passed
Huge thanks for your help on this @hanzei
|
/update-branch |
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>



Summary
Changes
uploadPlugin()inplugin.goto more descriptively handle the error case where an upload plugin exceeds the maximum file upload size prescribed by the server (by default, this maximum is 100 MB). Now, the server will respond with a 413 HTTP status code and anapi.plugin.upload.file_too_large.app_errorerror ID.Also changes
en.jsonto include an error message, "Uploaded plugin size exceeds limit." with the error ID mentioned above.Adds tests for this error handling in
plugin_test.go. Changesresources.goto symlinkplugin_api_teststo facilitate plugin tests. Maybe in the future we should moveplugin_api_teststo the standardtestsdirectory?Ticket Link
Fixes #26245
Jira https://mattermost.atlassian.net/browse/MM-56792
Release Note