New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove dependency on yasnippet-bundle #4

Closed
tarsius opened this Issue Jan 3, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@tarsius
Copy link
Contributor

tarsius commented Jan 3, 2017

yasnippet-bundle is... gone. I would tell you more if I knew, but unfortunately joaotavora/yasnippet@483364c is all I could find on the matter.

@npostavs any insights on this?

@tarsius

This comment has been minimized.

Copy link
Contributor

tarsius commented Jan 4, 2017

Please do the same for extend-dnd and r-autoyas.

@npostavs

This comment has been minimized.

Copy link

npostavs commented Jan 4, 2017

@npostavs any insights on this?

Not really, it was removed before I started contributing to yasnippet. AFAIK, yas-compile-snippets now implements similar functionality (that is, it puts a bunch of snippets into a single file).

@mattfidler

This comment has been minimized.

Copy link
Owner

mattfidler commented Jan 12, 2017

The current treatment uses

(require 'yasnippet-bundle nil t)

which will not require the library, unless it is present. This should allow for backward-compatability. Shouldn't this be sufficient for your needs?

@mattfidler

This comment has been minimized.

Copy link
Owner

mattfidler commented Jan 12, 2017

The same is true for el-autoyas and extend-dnd

@tarsius

This comment has been minimized.

Copy link
Contributor

tarsius commented Jan 12, 2017

Shouldn't this be sufficient for your needs?

My "need" is that I maintain the Emacsmirror and look into all dependency issues, which often involves contacting upstream.

"I want to keep this for backward compatibility" is good enough an answer for me. Since the Emacsmirror (like Melpa) is focused on the latest versions of all packages, I will explicitly drop the dependency on this obsolete library. Otherwise users would wounder "well, it's a soft dependency, so I don't need it, but what am I missing out on?".

On the other hand, are you sure these packages still work properly with recent yasnippet releases?

@tarsius tarsius closed this Jan 12, 2017

@mattfidler

This comment has been minimized.

Copy link
Owner

mattfidler commented Jan 12, 2017

Yes they work. I use them on recent versions.

@tarsius

This comment has been minimized.

Copy link
Contributor

tarsius commented Jan 12, 2017

Great! All good then. Thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment