Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[MGSplitViewController shouldAutorotateToInterfaceOrientation:] overrides autorotate settings defined in the detail view controller. #26

Merged
merged 1 commit into from Sep 19, 2012

Conversation

Projects
None yet
5 participants
Contributor

cvee commented Nov 6, 2010

[MGSplitViewController shouldAutorotateToInterfaceOrientation:] currently returns YES for all orientations. If custom autorotate settings are defined in the detail view controller (for example Landscape only), MGSplitViewController ignores these settings and continues to autorotate for all orientations.

The patch modifies [MGSplitViewController shouldAutorotateToInterfaceOrientation:] to return the value of [detailViewController shouldAutorotateToInterfaceOrientation:] if detailViewController is available. Otherwise, it defaults to YES.

@cvee cvee Fixed issue where [MGSplitViewController shouldAutorotateToInterfaceO…
…rientation:] would ignore autorotate settings defined in the detail view controller.
0d2d9cb

jpm commented Sep 7, 2011

+1 on this one.

raid5 commented Feb 3, 2012

+1 Why is this still not merged in? Such a useful and easy update.

+1, please merge that in!!

@mattgemmell mattgemmell added a commit that referenced this pull request Sep 19, 2012

@mattgemmell mattgemmell Merge pull request #26 from cvee/master
[MGSplitViewController shouldAutorotateToInterfaceOrientation:] overrides autorotate settings defined in the detail view controller.
d53f8de

@mattgemmell mattgemmell merged commit d53f8de into mattgemmell:master Sep 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment