setMasterViewController and setDetailViewController now remove former controller's view #49

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

felixLam commented Nov 7, 2011

Fixed an issue with setMasterViewController and setDetailViewController. Both failed to remove the view's of the old viewControllers which may lead to crashes if e.g. a tableView remains in the view hierarchy and tries to reload the content from the now deallocated viewController.

@felixLam felixLam Fixed an issue with setMasterViewController and setDetailViewControll…
…er. Both failed to remove the view's of the old viewControllers which may lead to crashes if e.g. a tableView remains in the view hierarchy and tries to reload the content from the now deallocated viewController.
185598a

ritzmo commented Nov 10, 2011

Just before this pull request I added a similar change to my working copy, though I had different reasons for this.
Reading the comment leads me to believe that this might explain some of the crash reports I received :D

So if anyone cares about my opinion, I'd give it a +1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment