Addressed issue 69 on mattgemmell/master #73

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
@ArtSabintsev

The fix adds iOS 6 compatibility.

@@ -519,6 +519,7 @@ - (void)viewDidAppear:(BOOL)animated
[self.masterViewController viewDidAppear:animated];
}
[self.detailViewController viewDidAppear:animated];
+ [self layoutSubviews];
}

This comment has been minimized.

Show comment Hide comment
@wedkarz

wedkarz Oct 12, 2012

Isn't it just temporal fix? layout subviews should be called in willAppear, because still bad layout is flashing firstly.
What might be the cause of different behaviour in iOS6? I noticed that problem occures only while building project using Xcode 4.5 (or rather iOS SDK 6.0). If you build using old one (i.e. 4.3.3) it still works fine, even if iOS 6 device.

@wedkarz

wedkarz Oct 12, 2012

Isn't it just temporal fix? layout subviews should be called in willAppear, because still bad layout is flashing firstly.
What might be the cause of different behaviour in iOS6? I noticed that problem occures only while building project using Xcode 4.5 (or rather iOS SDK 6.0). If you build using old one (i.e. 4.3.3) it still works fine, even if iOS 6 device.

This comment has been minimized.

Show comment Hide comment
@sam899

sam899 Oct 20, 2012

@ArtSabintsev , @wedkarz - I just submitted a pull request that doesn't have the flashing problem on load for iOS 6 - Could you see if it has a better result for you?

@sam899

sam899 Oct 20, 2012

@ArtSabintsev , @wedkarz - I just submitted a pull request that doesn't have the flashing problem on load for iOS 6 - Could you see if it has a better result for you?

This comment has been minimized.

Show comment Hide comment
@SunilJagnani123

SunilJagnani123 Nov 6, 2012

Its working from navigation controller now. Before it was not showing in landscape mode. the master part was going blank.

@SunilJagnani123

SunilJagnani123 Nov 6, 2012

Its working from navigation controller now. Before it was not showing in landscape mode. the master part was going blank.

@jackbellis

This comment has been minimized.

Show comment Hide comment
@jackbellis

jackbellis Feb 5, 2013

When i use your code, Art(?) it rotates properly. When I use Matt's it does not. Can anyone explain the differences? I diff-ed all the classes and only saw the one line about the layout and I don't spot what the effect is when i apply that change to Matt's. Thanks

When i use your code, Art(?) it rotates properly. When I use Matt's it does not. Can anyone explain the differences? I diff-ed all the classes and only saw the one line about the layout and I don't spot what the effect is when i apply that change to Matt's. Thanks

@ArtSabintsev

This comment has been minimized.

Show comment Hide comment
@ArtSabintsev

ArtSabintsev Feb 5, 2013

Instead of adding a subview, I reset the window's rootViewController (ArtSabintsev/MGSplitViewController@a63c963). I called layoutSubviews later on, to re-draw/orient the view on rotation.

Instead of adding a subview, I reset the window's rootViewController (ArtSabintsev/MGSplitViewController@a63c963). I called layoutSubviews later on, to re-draw/orient the view on rotation.

@jackbellis

This comment has been minimized.

Show comment Hide comment
@jackbellis

jackbellis Feb 5, 2013

Arggg... I had forgotten that the diff also picked that up, so I didn't try it in my experimenting. Thanks very much.

Arggg... I had forgotten that the diff also picked that up, so I didn't try it in my experimenting. Thanks very much.

@ArtSabintsev

This comment has been minimized.

Show comment Hide comment
@ArtSabintsev

ArtSabintsev Feb 5, 2013

My pleasure!

My pleasure!

@TrungVu37

This comment has been minimized.

Show comment Hide comment
@TrungVu37

TrungVu37 Feb 11, 2014

could you fix MGSplitView in storyboard IOS > 5 plz?

could you fix MGSplitView in storyboard IOS > 5 plz?

@ArtSabintsev

This comment has been minimized.

Show comment Hide comment
@ArtSabintsev

ArtSabintsev Feb 11, 2014

No, I will not be doing that, as iOS 7 has ~86% market share and iOS 6 has ~12% marketshare, which leaves iOS 1-4 with 2% market share. https://mixpanel.com/trends/#report/ios_7

There is no reason to support iOS 5 or iOS 6 at this point in time.

No, I will not be doing that, as iOS 7 has ~86% market share and iOS 6 has ~12% marketshare, which leaves iOS 1-4 with 2% market share. https://mixpanel.com/trends/#report/ios_7

There is no reason to support iOS 5 or iOS 6 at this point in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment