Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor LED panel fixes #110

Merged
merged 2 commits into from Mar 1, 2016

Conversation

Projects
None yet
2 participants
@ribbons
Copy link
Contributor

commented Mar 1, 2016

Just a couple of small commits to fix two minor LED panel niggles:

The first makes the background of the LED panel fully opaque - currently there is a transparent inner border between the div border and table which doesn't show up on the dark background, but is visible sometimes with a custom footer. I've set a partially white background in the below before and after for maximum visibility:

before after

The second evens up the spacing around the LED images when the text is hidden on small screens or in an iframe - here's another before and after:

before_vert after_vert

ribbons added some commits Mar 1, 2016

Remove transparent inner border from LED panel
Set the outer div's background to the same colour as the inner table.

mattgodbolt added a commit that referenced this pull request Mar 1, 2016

@mattgodbolt mattgodbolt merged commit b37b80d into mattgodbolt:master Mar 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mattgodbolt

This comment has been minimized.

Copy link
Owner

commented Mar 1, 2016

Thanks for this!

@mattgodbolt

This comment has been minimized.

Copy link
Owner

commented Mar 1, 2016

also pushed to live site. thanks again!

@ribbons ribbons deleted the ribbons:minor-led-fixes branch Mar 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.