Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dsd disc images via UI and URL params #81

Merged
merged 2 commits into from Aug 30, 2015

Conversation

Projects
None yet
2 participants
@ribbons
Copy link
Contributor

commented Aug 30, 2015

Internally, the baseSsd method in fdc.js supports dsd images if the dsd member is true, however this isn't exposed in the UI or via URL parameters.

This PR adds transparent handling of a disc image as dsd if it has the extension .dsd and is loaded via a URL parameter or using the UI to load a local image.

What I'm not sure about is if the functions I've changed (ssdFor and baseSsd) should be renamed to reflect that they don't just support SSDs - e.g. diskFor and baseDisk, or if they should be left as-is for compatibility? Let me know if they should be renamed and I'll update this PR.

Also included is a fix for a bug running the tests via a browser if the application isn't located in the root of a web server (which I discovered along the way).

ribbons added some commits Aug 30, 2015

Support dsd disc images via UI and URL params
Internally, the baseSsd method in fdc.js supports dsd images if the
'dsd' member is true, however this isn't exposed in the UI or via URL
parameters.  This adds transparent handling of a disc image as dsd if it
has the extension .dsd and is loaded via a URL parameter or using the UI.
@mattgodbolt

This comment has been minimized.

Copy link
Owner

commented Aug 30, 2015

Fantastic; thanks for this!

mattgodbolt added a commit that referenced this pull request Aug 30, 2015

Merge pull request #81 from ribbons/master
Support dsd disc images via UI and URL params

@mattgodbolt mattgodbolt merged commit 98c8149 into mattgodbolt:master Aug 30, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.