Revamp and C++ify notes #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* All C++ all the time * Mostly global-free. Only one singleton bridging to Xania * Tests! Still writes to area/notes.txt which means this does not help with #221, but at least we can test the fix as and when.
|
Some notes:
This is so low priority so don't fret. If I don't hear in a week or so I might merge anyway unless you have a strong feeling you want to look. This was more to get me back into Xania and C++ :) |
snellers
reviewed
Dec 31, 2020
snellers
reviewed
Dec 31, 2020
snellers
reviewed
Dec 31, 2020
snellers
reviewed
Dec 31, 2020
snellers
reviewed
Dec 31, 2020
snellers
reviewed
Dec 31, 2020
snellers
reviewed
Dec 31, 2020
snellers
reviewed
Dec 31, 2020
snellers
reviewed
Dec 31, 2020
snellers
reviewed
Dec 31, 2020
snellers
reviewed
Dec 31, 2020
snellers
reviewed
Dec 31, 2020
|
Looks nice! |
snellers
approved these changes
Dec 31, 2020
|
Well, one of the test hosts died with: so...time to work out what travesty I've managed to slip past the regular tests... I suspect I know actually, and it's something I meant to change! Watch this spaacespace. |
|
Thanks for the comprehensive review btw! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still writes to area/notes.txt which means this does not help with #221,
but at least we can test the fix as and when.